hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1214) Enable tracing for the datanode read/write path
Date Mon, 11 Mar 2019 16:08:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1214?focusedWorklogId=211096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211096
]

ASF GitHub Bot logged work on HDDS-1214:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Mar/19 16:07
            Start Date: 11/Mar/19 16:07
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on issue #550: HDDS-1214. Enable tracing for
the datanode read/write path
URL: https://github.com/apache/hadoop/pull/550#issuecomment-471606302
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 44 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests.
 Please justify why no new tests are needed for this patch. Also please list what manual steps
were performed to verify this patch. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 48 | Maven dependency ordering for branch |
   | +1 | mvninstall | 1177 | trunk passed |
   | +1 | compile | 79 | trunk passed |
   | +1 | checkstyle | 31 | trunk passed |
   | +1 | mvnsite | 78 | trunk passed |
   | +1 | shadedclient | 823 | branch has no errors when building and testing our client artifacts.
|
   | +1 | findbugs | 126 | trunk passed |
   | +1 | javadoc | 72 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 12 | Maven dependency ordering for patch |
   | +1 | mvninstall | 78 | the patch passed |
   | +1 | compile | 72 | the patch passed |
   | +1 | javac | 72 | the patch passed |
   | +1 | checkstyle | 26 | the patch passed |
   | +1 | mvnsite | 69 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 799 | patch has no errors when building and testing our client artifacts.
|
   | +1 | findbugs | 136 | the patch passed |
   | +1 | javadoc | 66 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 88 | common in the patch failed. |
   | -1 | unit | 62 | container-service in the patch failed. |
   | +1 | asflicense | 36 | The patch does not generate ASF License warnings. |
   | | | 3952 | |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
|
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-550/3/artifact/out/Dockerfile
|
   | GITHUB PR | https://github.com/apache/hadoop/pull/550 |
   | Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite 
unit  shadedclient  findbugs  checkstyle  |
   | uname | Linux 1c6b6adced10 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC
2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / ebb5fa1 |
   | maven | version: Apache Maven 3.3.9 |
   | Default Java | 1.8.0_191 |
   | findbugs | v3.1.0-RC1 |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-550/3/artifact/out/patch-unit-hadoop-hdds_common.txt
|
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-550/3/artifact/out/patch-unit-hadoop-hdds_container-service.txt
|
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-550/3/testReport/
|
   | Max. process+thread count | 319 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-550/3/console
|
   | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 211096)
    Time Spent: 50m  (was: 40m)

> Enable tracing for the datanode read/write path
> -----------------------------------------------
>
>                 Key: HDDS-1214
>                 URL: https://issues.apache.org/jira/browse/HDDS-1214
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Datanode
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> HDDS-1150 introduced distributed for ozone components. But we have no trace context propagation
between the clients and Ozone Datanodes.
> As we use Grpc and Ratis on this RPC path the full tracing could be quite complex: we
should propagate the trace id in Ratis and include it in all the log entries.
> I propose a simplified solution here: to trace only the StateMachine operations.
> As Ratis is a library we provide the implementation of the appropriate Raft elements
especially the StateMachine and the raft messages. We can add the tracing information to the
raft messages (in fact, we already have this field) and we can restore the tracing context
during the StateMachine operations.
> This approach is very simple (only a few lines of codes) and can show the time of the
real write/read operations, but can't see the internals of the Ratis operations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message