hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Wagle (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
Date Thu, 28 Mar 2019 22:59:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804037#comment-16804037
] 

Siddharth Wagle edited comment on HDDS-1189 at 3/28/19 10:58 PM:
-----------------------------------------------------------------

Hi [~linyiqun], thanks for the first review.

- ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the
generated DAO objects. I will add a unit test to make this point clear.

- Adding the javadoc for better understanding to JooqCodeGenerator. The main method of JooqCodeGenerator
is called by maven lifecycle to generate code.

- This is meant to be a skeleton patch that introduces all key components, specifically: codegen,
ORM and transactions without introducing noise. I will add more unit tests, certainly, but
want to keep it small enough to review and understand. The other tables will be added along
with API and logic to populate utilization data, in short, more functional in nature. Anybody
who wants to add a table gets POJOs and DAO for free with only need to add 1 function call
in the ShemaDefinition.


was (Author: swagle):
Hi [~linyiqun], thanks for the first review.

- ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the
generated DAO objects. I will add a unit test to make this point clear.

- This is meant to be a skeleton patch that introduces all key components, specifically: codegen,
ORM and transactions without introducing noise. I will add more unit tests, certainly, but
want to keep it small enough to review and understand. The other tables will be added along
with API and logic to populate utilization data, in short, more functional in nature. Anybody
who wants to add a table gets POJOs and DAO for free with only need to add 1 function call
in the ShemaDefinition.

> Recon Aggregate DB schema and ORM
> ---------------------------------
>
>                 Key: HDDS-1189
>                 URL: https://issues.apache.org/jira/browse/HDDS-1189
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>    Affects Versions: 0.5.0
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>            Priority: Major
>             Fix For: 0.5.0
>
>         Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch
>
>
> _Objectives_
> - Define V1 of the db schema for recon service
> - The current proposal is to use jOOQ as the ORM for SQL interaction. For two main reasons:
a) powerful DSL for querying, that abstracts out SQL dialects, b) Allows code to schema and
schema to code seamless transition, critical for creating DDL through the code and unit testing
across versions of the application.
> - Add e2e unit tests suite for Recon entities, created based on the design doc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message