hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lokesh Jain (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1128) Create stateful manager class for the pipeline creation scheduling
Date Mon, 04 Mar 2019 10:39:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783221#comment-16783221

Lokesh Jain commented on HDDS-1128:

v2 patch makes some changes based on comments by [~nandakumar131] in offline discussion.
There are some renaming changes and changes in the PipelineManager interface. The api for
finalizePipeline and removePipeline has been replaced by finalizeAndDestroyPipeline in the

> Create stateful manager class for the pipeline creation scheduling
> ------------------------------------------------------------------
>                 Key: HDDS-1128
>                 URL: https://issues.apache.org/jira/browse/HDDS-1128
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Elek, Marton
>            Assignee: Lokesh Jain
>            Priority: Critical
>         Attachments: HDDS-1128.001.patch, HDDS-1128.002.patch
> HDDS-1076 introduced a new static variable in RatisPipelineProvider: Scheduler. It seems
to be a global variable which makes the testing harder.
> [~shashikant] also suggested to remove it:
> {quote}It would be a good idea to move the scheduler Class Utility into some common utility
package so that it can be used in multiple places as and when needed. 
> {quote}
> I agree. And findbug also complains about it:
> {quote}H D ST: Write to static field org.apache.hadoop.hdds.scm.pipeline.RatisPipelineProvider.scheduler
from instance method new org.apache.hadoop.hdds.scm.pipeline.RatisPipelineProvider(NodeManager,
PipelineStateManager, Configuration)  At RatisPipelineProvider.java:[line 56]
> {quote}
> I think we need a new class which includes both the state of RatisPipelineUtils.isPipelineCreatorRunning
and RaitsPipelineProvider.Scheduler. It should have one instance which is available for the
classes which requires it.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message