hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1043) Enable token based authentication for S3 api
Date Wed, 06 Mar 2019 14:50:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1043?focusedWorklogId=208860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-208860
]

ASF GitHub Bot logged work on HDDS-1043:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Mar/19 14:49
            Start Date: 06/Mar/19 14:49
    Worklog Time Spent: 10m 
      Work Description: elek commented on pull request #561: HDDS-1043. Enable token based
authentication for S3 api.
URL: https://github.com/apache/hadoop/pull/561#discussion_r262834046
 
 

 ##########
 File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneServiceProvider.java
 ##########
 @@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.s3;
+
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.security.SecurityUtil;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.enterprise.inject.Produces;
+import javax.inject.Inject;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * This class creates the OM service .
+ */
+@ApplicationScoped
+public class OzoneServiceProvider {
+
+  private static final AtomicReference<Text> OM_SERVICE_ADD =
 
 Review comment:
   I don't think we need this static magic. I think with ApplicationScoped only one instance
of this class will be created.  I think it should work without the static.
   
   And instead of the AtomicReference you can use PostConstruct annotation:
   
   https://docs.oracle.com/javaee/6/tutorial/doc/gmgkd.html
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 208860)
    Time Spent: 23h 10m  (was: 23h)

> Enable token based authentication for S3 api
> --------------------------------------------
>
>                 Key: HDDS-1043
>                 URL: https://issues.apache.org/jira/browse/HDDS-1043
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Blocker
>              Labels: pull-request-available, security
>             Fix For: 0.4.0
>
>         Attachments: HDDS-1043.00.patch, HDDS-1043.01.patch, HDDS-1043.02.patch, HDDS-1043.03.patch,
HDDS-1043.04.patch, HDDS-1043.05.patch, HDDS-1043.06.patch, HDDS-1043.07.patch
>
>          Time Spent: 23h 10m
>  Remaining Estimate: 0h
>
> Ozone has a  S3 api and mechanism to create S3 like secrets for user. This jira proposes
hadoop compatible token based authentication for S3 api which utilizes S3 secret stored in
OM.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message