hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-596) Add robot test for OM Block Token
Date Mon, 11 Mar 2019 16:28:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-596?focusedWorklogId=211106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211106

ASF GitHub Bot logged work on HDDS-596:

                Author: ASF GitHub Bot
            Created on: 11/Mar/19 16:27
            Start Date: 11/Mar/19 16:27
    Worklog Time Spent: 10m 
      Work Description: ajayydv commented on pull request #581: HDDS-596. Add robot test for
OM Block Token.
URL: https://github.com/apache/hadoop/pull/581#discussion_r264316989

 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/authority/DefaultCAServer.java
 @@ -224,12 +224,16 @@ private KeyPair getCAKeys() throws IOException {
-        X509CertificateHolder xcert = approver.sign(config,
-            getCAKeys().getPrivate(),
-            getCACertificate(), java.sql.Date.valueOf(beginDate),
-            java.sql.Date.valueOf(endDate), csr, scmID, clusterID);
-        store.storeValidCertificate(xcert.getSerialNumber(),
-            CertificateCodec.getX509Certificate(xcert));
+        X509CertificateHolder xcert;
+        try {
+          xcert = signAndStoreCertificate(beginDate, endDate, csr);
+        } catch (SCMSecurityException e) {
+          // Certificate with conflicting serial id, retry again may resolve
 Review comment:
   faced in our docker testing, multiple Dns may send csr simultaneously, SCM throws error
for few of them saying serial id already exist. This small change resolves it but we should
refactor it for SCM HA.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 211106)
    Time Spent: 50m  (was: 40m)

> Add robot test for OM Block Token 
> ----------------------------------
>                 Key: HDDS-596
>                 URL: https://issues.apache.org/jira/browse/HDDS-596
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Xiaoyu Yao
>            Assignee: Ajay Kumar
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message