hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-596) Add robot test for OM Block Token
Date Sat, 09 Mar 2019 17:55:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-596?focusedWorklogId=210587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-210587
]

ASF GitHub Bot logged work on HDDS-596:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Mar/19 17:54
            Start Date: 09/Mar/19 17:54
    Worklog Time Spent: 10m 
      Work Description: xiaoyuyao commented on pull request #581: HDDS-596. Add robot test
for OM Block Token.
URL: https://github.com/apache/hadoop/pull/581#discussion_r264008052
 
 

 ##########
 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/authority/DefaultCAServer.java
 ##########
 @@ -224,12 +224,16 @@ private KeyPair getCAKeys() throws IOException {
         break;
       case KERBEROS_TRUSTED:
       case TESTING_AUTOMATIC:
-        X509CertificateHolder xcert = approver.sign(config,
-            getCAKeys().getPrivate(),
-            getCACertificate(), java.sql.Date.valueOf(beginDate),
-            java.sql.Date.valueOf(endDate), csr, scmID, clusterID);
-        store.storeValidCertificate(xcert.getSerialNumber(),
-            CertificateCodec.getX509Certificate(xcert));
+        X509CertificateHolder xcert;
+        try {
+          xcert = signAndStoreCertificate(beginDate, endDate, csr);
+        } catch (SCMSecurityException e) {
+          // Certificate with conflicting serial id, retry again may resolve
 
 Review comment:
   why we would have duplicate serial id? is that because the serial id generator based on
time where multiple csr requests at the same time?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 210587)
    Time Spent: 0.5h  (was: 20m)

> Add robot test for OM Block Token 
> ----------------------------------
>
>                 Key: HDDS-596
>                 URL: https://issues.apache.org/jira/browse/HDDS-596
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Xiaoyu Yao
>            Assignee: Ajay Kumar
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message