From hdfs-issues-return-252835-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Sat Feb 23 02:34:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 44D2E180648 for ; Sat, 23 Feb 2019 03:34:05 +0100 (CET) Received: (qmail 52834 invoked by uid 500); 23 Feb 2019 02:34:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 52823 invoked by uid 99); 23 Feb 2019 02:34:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Feb 2019 02:34:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A4206C2696 for ; Sat, 23 Feb 2019 02:34:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jlVbEa-iUJhs for ; Sat, 23 Feb 2019 02:34:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A958462437 for ; Sat, 23 Feb 2019 02:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B5EE6E2777 for ; Sat, 23 Feb 2019 02:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2D23E24479 for ; Sat, 23 Feb 2019 02:34:00 +0000 (UTC) Date: Sat, 23 Feb 2019 02:34:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HDDS-1158) TestOzoneManagerHA.testTwoOMNodesDown is failing with ratis error MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1158?focusedWorklogId=3D2= 02967&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-202967 ] ASF GitHub Bot logged work on HDDS-1158: ---------------------------------------- Author: ASF GitHub Bot Created on: 23/Feb/19 02:33 Start Date: 23/Feb/19 02:33 Worklog Time Spent: 10m=20 Work Description: hanishakoneru commented on pull request #512: HDDS-= 1158. TestOzoneManagerHA.testTwoOMNodesDown is failing with ratis error. URL: https://github.com/apache/hadoop/pull/512#discussion_r259561458 =20 =20 ########## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/o= zone/om/TestOzoneManagerHA.java ########## @@ -150,17 +152,27 @@ private void testCreateVolume(boolean checkSuccess) = throws Exception { createVolumeArgs.setUserName(userName); createVolumeArgs.setAdminName(adminName); =20 - storageHandler.createVolume(createVolumeArgs); + try { + storageHandler.createVolume(createVolumeArgs); =20 - VolumeArgs getVolumeArgs =3D new VolumeArgs(volumeName, userArgs); - VolumeInfo retVolumeinfo =3D storageHandler.getVolumeInfo(getVolumeArg= s); + VolumeArgs getVolumeArgs =3D new VolumeArgs(volumeName, userArgs); + VolumeInfo retVolumeinfo =3D storageHandler.getVolumeInfo(getVolumeA= rgs); =20 - if (checkSuccess) { - Assert.assertTrue(retVolumeinfo.getVolumeName().equals(volumeName)); - Assert.assertTrue(retVolumeinfo.getOwner().getName().equals(userName= )); - } else { - // Verify that the request failed - Assert.assertTrue(retVolumeinfo.getVolumeName().isEmpty()); + if (checkSuccess) { + Assert.assertTrue(retVolumeinfo.getVolumeName().equals(volumeName)= ); + Assert.assertTrue(retVolumeinfo.getOwner().getName().equals(userNa= me)); + } else { + // Verify that the request failed + Assert.assertTrue(retVolumeinfo.getVolumeName().isEmpty()); + Assert.fail("There is no quorum. Request should have failed"); + } + } catch (OMException e) { + if (!checkSuccess) { + GenericTestUtils.assertExceptionContains( + "RaftRetryFailureException", e); =20 Review comment: Hi @bharatviswa504, This particular test case if for when we have 2 OM nodes down. So even w= ith retry and failover logic implemented, the request should eventually fai= l.=20 =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 202967) Time Spent: 50m (was: 40m) > TestOzoneManagerHA.testTwoOMNodesDown is failing with ratis error > ----------------------------------------------------------------- > > Key: HDDS-1158 > URL: https://issues.apache.org/jira/browse/HDDS-1158 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Elek, Marton > Assignee: Hanisha Koneru > Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > h3. Error Message > {code:java} > org.apache.ratis.protocol.RaftRetryFailureException: Failed RaftClientReq= uest:client-4D77D2A8F653->omNode-3@group-523986131536, cid=3D9, seq=3D0 RW,= org.apache.hadoop.ozone.om.ratis.OzoneManagerRatisClient$$Lambda$373/20675= 04307@6afa0221 for 10 attempts with RetryLimited(maxAttempts=3D10, sleepTim= e=3D100ms){code} > Stacktrace > {code:java} > INTERNAL_ERROR org.apache.hadoop.ozone.om.exceptions.OMException: org.apa= che.ratis.protocol.RaftRetryFailureException: Failed RaftClientRequest:clie= nt-4D77D2A8F653->omNode-3@group-523986131536, cid=3D9, seq=3D0 RW, org.apac= he.hadoop.ozone.om.ratis.OzoneManagerRatisClient$$Lambda$373/2067504307@6af= a0221 for 10 attempts with RetryLimited(maxAttempts=3D10, sleepTime=3D100ms= ) at org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTr= anslatorPB.handleError(OzoneManagerProtocolClientSideTranslatorPB.java:586)= at org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTra= nslatorPB.createVolume(OzoneManagerProtocolClientSideTranslatorPB.java:230)= at org.apache.hadoop.ozone.web.storage.DistributedStorageHandler.createVol= ume(DistributedStorageHandler.java:179) at org.apache.hadoop.ozone.om.TestO= zoneManagerHA.testCreateVolume(TestOzoneManagerHA.java:153) at org.apache.h= adoop.ozone.om.TestOzoneManagerHA.testTwoOMNodesDown(TestOzoneManagerHA.jav= a:138) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at su= n.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)= at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso= rImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.j= unit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java= :47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveC= allable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosive= ly(FrameworkMethod.java:44) at org.junit.internal.runners.statements.Invoke= Method.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.stateme= nts.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.s= tatements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.Expected= Exception$ExpectedExceptionStatement.evaluate(ExpectedException.java:168) a= t org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(F= ailOnTimeout.java:74){code} > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org