From hdfs-issues-return-250776-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Feb 8 23:30:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 95D1918060E for ; Sat, 9 Feb 2019 00:30:03 +0100 (CET) Received: (qmail 87493 invoked by uid 500); 8 Feb 2019 23:30:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 87477 invoked by uid 99); 8 Feb 2019 23:30:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Feb 2019 23:30:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 297AB181A36 for ; Fri, 8 Feb 2019 23:30:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id kynJeD_gHDO4 for ; Fri, 8 Feb 2019 23:30:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CBC375F575 for ; Fri, 8 Feb 2019 23:30:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 65526E2740 for ; Fri, 8 Feb 2019 23:30:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2152224453 for ; Fri, 8 Feb 2019 23:30:00 +0000 (UTC) Date: Fri, 8 Feb 2019 23:30:00 +0000 (UTC) From: "Shweta (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDFS-14260) Synchronized Method in BlockReceiver Can Be Replaced with Atomic Value MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763958#comment-16763958 ] Shweta edited comment on HDFS-14260 at 2/8/19 11:29 PM: -------------------------------------------------------- Thanks for the patch [~belugabehr]. Looks good to me. Just curious, does this change improve performance that you noticed? was (Author: shwetayakkali): Thanks for the [~belugabehr]. Looks good to me. Just curious, does this change improve performance that you noticed? > Synchronized Method in BlockReceiver Can Be Replaced with Atomic Value > ---------------------------------------------------------------------- > > Key: HDFS-14260 > URL: https://issues.apache.org/jira/browse/HDFS-14260 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 3.2.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Attachments: HDFS-14260.1.patch, HDFS-14260.2.patch > > > This synchronized block is protecting {{lastSentTime}} which is a native long. Can use AtomicLong and remove this synchronization. > {code} > synchronized boolean packetSentInTime() { > long diff = Time.monotonicNow() - lastSentTime; > if (diff > maxSendIdleTime) { > LOG.info("A packet was last sent " + diff + " milliseconds ago."); > return false; > } > return true; > } > {code} > https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java#L392-L399 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org