From hdfs-issues-return-250800-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Sat Feb 9 04:19:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7D94F18060E for ; Sat, 9 Feb 2019 05:19:04 +0100 (CET) Received: (qmail 18071 invoked by uid 500); 9 Feb 2019 04:19:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 18060 invoked by uid 99); 9 Feb 2019 04:19:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Feb 2019 04:19:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D3115C5CB0 for ; Sat, 9 Feb 2019 04:19:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id OayoT3MvqgNX for ; Sat, 9 Feb 2019 04:19:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 830086243B for ; Sat, 9 Feb 2019 04:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A44BBE2748 for ; Sat, 9 Feb 2019 04:19:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2566A24458 for ; Sat, 9 Feb 2019 04:19:00 +0000 (UTC) Date: Sat, 9 Feb 2019 04:19:00 +0000 (UTC) From: "Xiaoyu Yao (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDDS-1012) Add Default CertificateClient implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1012?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16764= 066#comment-16764066 ]=20 Xiaoyu Yao commented on HDDS-1012: ---------------------------------- Thanks [~ajayydv] for the update. Few minor comments, +1 after that being f= ixed. =C2=A0 CertificateClient.java Line 152: can we remove the OM init() implementation details from the inter= face docs? =C2=A0 CertificateClientTestImpl.java Line 147-150: NIT: these comments can be removed. =C2=A0 OMCertificateClient.java Line 42: should we pass LOG to super() so that the base class has the corre= ct LOG message? Similar apply to DNCertificateClient LOG. =C2=A0 =C2=A0 =C2=A0 =C2=A0 > Add Default CertificateClient implementation > -------------------------------------------- > > Key: HDDS-1012 > URL: https://issues.apache.org/jira/browse/HDDS-1012 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Priority: Major > Labels: Blocker > Attachments: HDDS-1012.01.patch, HDDS-1012.02.patch, HDDS-1012.03= .patch, HDDS-1012.04.patch, HDDS-1012.05.patch, HDDS-1012.06.patch, HDDS-10= 12.07.patch, HDDS-1012.08.patch > > > Add Default CertificateClient implementation -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org