From hdfs-issues-return-250195-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Feb 4 18:33:52 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A5E9C180651 for ; Mon, 4 Feb 2019 19:33:51 +0100 (CET) Received: (qmail 2283 invoked by uid 500); 4 Feb 2019 18:33:50 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 2267 invoked by uid 99); 4 Feb 2019 18:33:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2019 18:33:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2CB8FCB978 for ; Mon, 4 Feb 2019 18:33:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6aPZQqEzpG07 for ; Mon, 4 Feb 2019 18:33:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EA20160FB0 for ; Mon, 4 Feb 2019 18:26:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 82EE3E2673 for ; Mon, 4 Feb 2019 18:26:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 43F8B243FB for ; Mon, 4 Feb 2019 18:26:00 +0000 (UTC) Date: Mon, 4 Feb 2019 18:26:00 +0000 (UTC) From: =?utf-8?Q?=C3=8D=C3=B1igo_Goiri_=28JIRA=29?= To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-14210) RBF: ModifyACL should work over all the destinations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-14210?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1676= 0088#comment-16760088 ]=20 =C3=8D=C3=B1igo Goiri commented on HDFS-14210: ------------------------------------ I'm not sure we should do this for everybody all the time. HASH_ALL and so on, yes they need it but HASH or others should be executed = in the ones that succeed. We should have tests for different mount points, right now all of them are = for a single destination which actually don't really test this. A few other minor comments: * Fix the checkstyle. * User {{assertNotEquals()}} instead of assert false for equals. * Fix capitalization to {{testRemoveAclEntries()}}, {{testSetAcl()}} and {{= testModifyAclEntries()}}. * Don't use javadoc comment in TestRouterACL#112,228. * The test takes very long as we are setting up a cluster for every test; w= e should make it @BeforeClass and @AfterClass. * The mount points could be created in the beginning. * You may want to set {{routerProtocol}} in the class itself instead of doi= ng it for every test. Actually, setting up the folders and deleting them co= uld be done in @Before and @After. > RBF: ModifyACL should work over all the destinations > ---------------------------------------------------- > > Key: HDFS-14210 > URL: https://issues.apache.org/jira/browse/HDFS-14210 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Shubham Dewan > Assignee: Shubham Dewan > Priority: Major > Attachments: HDFS-14210-HDFS-13891.002.patch, HDFS-14210-HDFS-138= 91.003.patch, HDFS-14210.001.patch > > > 1) A mount point with multiple destinations. > 2)=C2=A0./bin/hdfs dfs -setfacl -m user:abc:rwx /testacl > 3) where /testacl =3D> /test1, /test2 > 4) command works for only one destination. > ACL should be set on both of the destinations. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org