hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1080) Ozonefs Isolated class loader should support FsStorageStatistics
Date Mon, 11 Feb 2019 12:21:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764907#comment-16764907
] 

Hadoop QA commented on HDDS-1080:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 18s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 18s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue}
Skipped patched modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m  0s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 34s{color} |
{color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 54s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 16s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue}
Skipped patched modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m  0s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 34s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 12s{color} | {color:red}
hadoop-ozone in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m 45s{color} | {color:red}
hadoop-hdds in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 17s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 51s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.client.rpc.TestOzoneRpcClient |
|   | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
|   | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
|   | hadoop.ozone.om.TestOmInit |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-1080 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12958236/HDDS-1080.001.patch
|
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  checkstyle  |
| uname | Linux 9c3bed19db6b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HDDS-Build/ozone.sh |
| git revision | trunk / e7d1ae5 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/2223/artifact/out/patch-unit-hadoop-ozone.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/2223/artifact/out/patch-unit-hadoop-hdds.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/2223/testReport/ |
| Max. process+thread count | 1226 (vs. ulimit of 10000) |
| modules | C: hadoop-ozone/ozonefs U: hadoop-ozone/ozonefs |
| Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/2223/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Ozonefs Isolated class loader should support FsStorageStatistics
> ----------------------------------------------------------------
>
>                 Key: HDDS-1080
>                 URL: https://issues.apache.org/jira/browse/HDDS-1080
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Filesystem
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>         Attachments: HDDS-1080.001.patch
>
>
> HDDS-1033 introduced the storage statistics for ozonefs. Unfortunately the isolated classloader
(HDDS-922) doesn't work any more after this change.
> To explain the problem, let's use the specific expression _classname[classloader]_ for
a class (named by classname) which is loaded by the classloader.
> We have two classloaders the _main_ which is the standard classloader of the application
and the _isolated_ classloader which is created by the OzoneClientAdapterFactory.java.
> By default java classloaders delegate the loading to the parent class loader, and they
load all the classes from the parent first (if possible). The isolated class loader does the
oposit, loads all the classes from a specific location of the jar files. With this approach
we can use hadoop3.2+ozone classes together with older hadoop versions.
> But back to the problem:
> OzoneFilesystem[main] is loaded by the application. In this class an OzoneFSStorageStatistics[main]
is created and with the help of OzoneClientAdapterFactory[main] a new OzoneClientAdapterImpl[isolated!!]
is instantiated which implements the OzoneClientAdapter[main] and will do all the main work[isolated].
> OzoneClientAdapterImp[isolated] has a new constructor which requires (String[system],
String[system], OzoneFSStorageStatistics[isolated]). 
> And this is the problem, it requires OzoneFSStorageStatistics[isolated] but we have a
 OzoneFSStorageStatistics[main].
> The fix is very straightforward. In the FilteredClassLoader.java we ha a list for the
classes which should be shared by the two classloaders. For these classes the isolated classloader
will delegate the loading to the parent ([main]) classloader and we will have one (and only
one) OzoneFSStorageStatistics[main] everywhere.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message