hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1070) Adding Node and Pipeline related metrics in SCM
Date Sat, 09 Feb 2019 11:52:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764124#comment-16764124
] 

Yiqun Lin commented on HDDS-1070:
---------------------------------

Thanks [~nandakumar131] for working on this. The patch looks good overall, some initial comments:

*SCMNodeManager*
 * Can we add {{final}} for {{private SCMNodeMetrics metrics}}?

*SCMNodeMetrics*
 * Why not also add the failure counter for HB/NodeReportProcessed? It will be also useful
I think.
 * Looks like the metric name can be simplified to a {{numHBProcessed(fails)/numNodeReportProcessed(fails)}}?
The naming rule can be numOperation or numOperationfails.
 * We lack of one {{unRegister}} function. And this function will be used in {{SCMNodeManager#close}}

*SCMPipelineMetrics*
 * The metrcis name follow the above way mentioned. The corresponding function name can also
be simplified. This will make metric names/functions look not so long.

Can we add three unit test corresponding to SCMNodeMetrics, SCMPipelineMetrics and PipelineManagerMXBean?
For the metric UT, we can do test like TestOmMetrics did.

> Adding Node and Pipeline related metrics in SCM
> -----------------------------------------------
>
>                 Key: HDDS-1070
>                 URL: https://issues.apache.org/jira/browse/HDDS-1070
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: SCM
>    Affects Versions: 0.3.0
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>            Priority: Major
>         Attachments: HDDS-1070.000.patch
>
>
> This jira aims to add more Node and Pipeline related metrics to SCM.
> Following metrics will be added as part of this jira:
>  * numberOfSuccessfulPipelineCreation
>  * numberOfFailedPipelineCreation
>  * numberOfSuccessfulPipelineDestroy
>  * numberOfFailedPipelineDestroy
>  * numberOfPipelineReportProcessed
>  * numberOfNodeReportProcessed
>  * numberOfHBProcessed
>  * number of pipelines in different PipelineState



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message