hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nanda kumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1048) Remove SCMNodeStat from SCMNodeManager and use storage information from DatanodeInfo#StorageReportProto
Date Fri, 08 Feb 2019 09:47:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763450#comment-16763450
] 

Nanda kumar commented on HDDS-1048:
-----------------------------------

Thanks [~linyiqun] for the review. I have addressed all the review comments in patch v01.

> Why not refactor the test testStatisticsUpdate instead of ignoring this?
The reason I didn't want to do that because it felt kinda hacky, anyway removed the @Ignore
and made the test-case work :)

> Remove SCMNodeStat from SCMNodeManager and use storage information from DatanodeInfo#StorageReportProto
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HDDS-1048
>                 URL: https://issues.apache.org/jira/browse/HDDS-1048
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: SCM
>    Affects Versions: 0.3.0
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>            Priority: Major
>         Attachments: HDDS-1048.000.patch, HDDS-1048.001.patch
>
>
> We don't have to maintain SCMNodeStat in SCMNodeManager anymore. This information can
be obtained from {{DatanodeInfo#StorageReportProto}} inside NodeStateMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message