hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1047) Fix TestRatisPipelineProvider#testCreatePipelineWithFactor
Date Fri, 08 Feb 2019 01:48:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763226#comment-16763226
] 

Yiqun Lin commented on HDDS-1047:
---------------------------------

Thanks [~nilotpalnandi] for addressing the comment. Some nitpicks:
 * I would not change the indentation of the some lines. Seems not correct.

*TestRatisPipelineProvider*
 Line56: can be removed.
 Line65 Can be removed. 
 Then rename parameter name from {{replicationFactor}} to {{factor}}. +1 once addressed.

> Fix TestRatisPipelineProvider#testCreatePipelineWithFactor
> ----------------------------------------------------------
>
>                 Key: HDDS-1047
>                 URL: https://issues.apache.org/jira/browse/HDDS-1047
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Lokesh Jain
>            Assignee: Nilotpal Nandi
>            Priority: Major
>         Attachments: HDDS-1047.001.patch, HDDS-1047.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message