hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Risden (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-14251) BlockPoolSlice ForkJoinPool introduced by HDFS-13768 breaks under Java SecurityManager
Date Fri, 01 Feb 2019 13:51:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758313#comment-16758313
] 

Kevin Risden edited comment on HDFS-14251 at 2/1/19 1:50 PM:
-------------------------------------------------------------

Another note about the addReplicaThreadPool ForkJoinPool in BlockPoolSlice, it is never shutdown
during the BlockPoolSlice.shutdown(...) method. The shutdown hook is cleaned up but the addReplicaThreadPool
is only ever shutdown in the shutdown hook. HDFS-12984 cleaned up the shutdown hook but -HDFS-13768- assumed
that the shutdown hook would be called.

I can create a separate ticket for this if needed but found while looking at BlockPoolSlice
and the ForkJoinPool.


was (Author: risdenk):
Another note about the addReplicaThreadPool ForkJoinPool in BlockPoolSlice, it is never shutdown
during the BlockPoolSlice.shutdown(...) method. The shutdown hook is cleaned up but the addReplicaThreadPool
is only ever shutdown in the shutdown hook. HDFS-12984 cleaned up the shutdown hook but -HDFS-13768- assumed
that the shutdown hook would be called.

> BlockPoolSlice  ForkJoinPool introduced by HDFS-13768 breaks under Java SecurityManager
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-14251
>                 URL: https://issues.apache.org/jira/browse/HDFS-14251
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.10.0, 3.2.0, 3.1.2
>            Reporter: Kevin Risden
>            Priority: Major
>
> HDFS-13768 introduced ForkJoinPool to improve performance of BlockPoolSlice. The created
ForkJoinPool doesn't pass in a custom thread factory and by default the thread factory prevents
all privileges under the Java SecurityManager.
> This broke when integrating Hadoop 3.2.0 with Apache Solr in SOLR-9515.
> It isn't clear that the ForkJoinPool is necessary when a regular normal executor could
work instead?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message