hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1012) Add Default CertificateClient implementation
Date Sat, 09 Feb 2019 04:19:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764066#comment-16764066
] 

Xiaoyu Yao commented on HDDS-1012:
----------------------------------

Thanks [~ajayydv] for the update. Few minor comments, +1 after that being fixed.

 

CertificateClient.java

Line 152: can we remove the OM init() implementation details from the interface docs?

 

CertificateClientTestImpl.java

Line 147-150: NIT: these comments can be removed.

 

OMCertificateClient.java

Line 42: should we pass LOG to super() so that the base class has the correct LOG message?
Similar apply to DNCertificateClient LOG.

 

 

 

 

> Add Default CertificateClient implementation
> --------------------------------------------
>
>                 Key: HDDS-1012
>                 URL: https://issues.apache.org/jira/browse/HDDS-1012
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>              Labels: Blocker
>         Attachments: HDDS-1012.01.patch, HDDS-1012.02.patch, HDDS-1012.03.patch, HDDS-1012.04.patch,
HDDS-1012.05.patch, HDDS-1012.06.patch, HDDS-1012.07.patch, HDDS-1012.08.patch
>
>
> Add Default CertificateClient implementation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message