hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-14158) Checkpointer ignores configured time period > 5 minutes
Date Mon, 04 Feb 2019 04:53:01 GMT

     [ https://issues.apache.org/jira/browse/HDFS-14158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Akira Ajisaka updated HDFS-14158:
---------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 3.3.0
           Status: Resolved  (was: Patch Available)

Committed this to trunk. Thanks [~tiwalter] for the contribution.

> Checkpointer ignores configured time period > 5 minutes
> -------------------------------------------------------
>
>                 Key: HDFS-14158
>                 URL: https://issues.apache.org/jira/browse/HDFS-14158
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.8.1
>            Reporter: Timo Walter
>            Assignee: Timo Walter
>            Priority: Minor
>              Labels: checkpoint, hdfs, namenode
>             Fix For: 3.3.0
>
>         Attachments: 449.patch, HDFS-14158-trunk-001.patch, HDFS-14158-trunk-002.patch
>
>
> The checkpointer always triggers a checkpoint every 5 minutes and ignores the flag "*dfs.namenode.checkpoint.period*",
if its greater than 5 minutes.
> See the code below (in Checkpointer.java):
> {code:java}
> //Main work loop of the Checkpointer
> public void run() {
>   // Check the size of the edit log once every 5 minutes.
>   long periodMSec = 5 * 60;   // 5 minutes
>   if(checkpointConf.getPeriod() < periodMSec) {
>     periodMSec = checkpointConf.getPeriod();
>   }
> {code}
> If the configured period ("*dfs.namenode.checkpoint.period*") is lower than 5 minutes,
you choose use the configured one. But it always ignores it, if it's greater than 5 minutes.
>  
> In my opinion, the if-expression should be:
> {code:java}
> if(checkpointConf.getPeriod() > periodMSec) {
>     periodMSec = checkpointConf.getPeriod();
>   }
> {code}
>  
> Then "*dfs.namenode.checkpoint.period*" won't get ignored.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message