hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-935) Avoid creating an already created container on a datanode in case of disk removal followed by datanode restart
Date Mon, 04 Feb 2019 10:30:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759749#comment-16759749
] 

Hadoop QA commented on HDDS-935:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 33s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 5 new or modified test files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 40s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 45s{color}
| {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue}
Skipped patched modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m  0s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 42s{color} |
{color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 57s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 37s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue}
Skipped patched modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m  0s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 29s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 40m 13s{color} | {color:red}
hadoop-ozone in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  6m  6s{color} | {color:green}
hadoop-hdds in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 20s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 55s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
|
|   | hadoop.hdds.scm.pipeline.TestSCMRestart |
|   | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
|   | hadoop.ozone.container.TestContainerReplication |
|   | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
|   | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-935 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12957486/HDDS-935.004.patch
|
| Optional Tests |  asflicense  unit  javac  javadoc  findbugs  checkstyle  |
| uname | Linux f1287b4f006c 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16
UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HDDS-Build/ozone.sh |
| git revision | trunk / 604b248 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/2172/artifact/out/patch-unit-hadoop-ozone.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/2172/testReport/ |
| Max. process+thread count | 1117 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test
hadoop-ozone/tools U: . |
| Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/2172/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Avoid creating an already created container on a datanode in case of disk removal followed
by datanode restart
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HDDS-935
>                 URL: https://issues.apache.org/jira/browse/HDDS-935
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Datanode
>    Affects Versions: 0.4.0
>            Reporter: Rakesh R
>            Assignee: Shashikant Banerjee
>            Priority: Major
>         Attachments: HDDS-935.000.patch, HDDS-935.001.patch, HDDS-935.002.patch, HDDS-935.003.patch,
HDDS-935.004.patch
>
>
> Currently, a container gets created when a writeChunk request comes to HddsDispatcher
and if the container does not exist already. In case a disk on which a container exists gets
removed and datanode restarts and now, if a writeChunkRequest comes , it might end up creating
the same container again with an updated BCSID as it won't detect the disk is removed. This
won't be detected by SCM as well as it will have the latest BCSID. This Jira aims to address
this issue.
> The proposed fix would be to persist the all the containerIds existing in the containerSet
when a ratis snapshot is taken in the snapshot file. If the disk is removed and dn gets restarted,
the container set will be rebuild after scanning all the available disks and the the container
list stored in the snapshot file will give all the containers created in the datanode. The
diff between these two will give the exact list of containers which were created but were
not detected after the restart. Any writeChunk request now should validate the container Id
from the list of missing containers. Also, we need to ensure container creation does not happen
as part of applyTransaction of writeChunk request in Ratis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message