hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9596) Remove "Shuffle" Method From DFSUtil
Date Sun, 03 Feb 2019 20:42:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759526#comment-16759526
] 

Hadoop QA commented on HDFS-9596:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  9s{color} | {color:red}
HDFS-9596 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-9596 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12957460/HIVE-20797.6.patch
|
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/26138/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Remove "Shuffle" Method From DFSUtil
> ------------------------------------
>
>                 Key: HDFS-9596
>                 URL: https://issues.apache.org/jira/browse/HDFS-9596
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HDFS-9596.2.patch, HDFS-9596.3.patch, HDFS-9596.4.patch, HDFS-9596.5.patch,
HIVE-20797.6.patch, Shuffle.HDFS-9596.patch
>
>
> DFSUtil contains a "shuffle" routine that shuffles arrays.  With a little wrapping, Java
Collections class can shuffle.  This code is superfluous and undocumented.  The method returns
an array, though it does not specify if it returns the same array or a new, copy, array of
shuffled items.
> It is only used in one place, so it is better to simply remove and substitute this implementation
with the java Collections implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message