From hdfs-issues-return-248498-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Sat Jan 19 07:57:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 94414180652 for ; Sat, 19 Jan 2019 07:57:05 +0100 (CET) Received: (qmail 73514 invoked by uid 500); 19 Jan 2019 06:57:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 73503 invoked by uid 99); 19 Jan 2019 06:57:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Jan 2019 06:57:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2F56BD2E02 for ; Sat, 19 Jan 2019 06:57:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id dkkqWVcKUvHR for ; Sat, 19 Jan 2019 06:57:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 466E260DA2 for ; Sat, 19 Jan 2019 06:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7B36CE2072 for ; Sat, 19 Jan 2019 06:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 108E72566A for ; Sat, 19 Jan 2019 06:57:00 +0000 (UTC) Date: Sat, 19 Jan 2019 06:57:00 +0000 (UTC) From: "lujie (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-14216) NullPointerException happens in NamenodeWebHdfs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-14216?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HDFS-14216: ------------------------- Description:=20 =C2=A0workload {code:java} curl -i -X PUT -T $HOMEPARH/test.txt "http://hadoop1:9870/webhdfs/v1/input?= op=3DCREATE&excludedatanodes=3Dhadoop2" {code} the method {code:java} org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMethods= .chooseDatanode(String excludeDatanodes){ =C2=A0 =C2=A0 HashSet excludes =3D new HashSet(); if (excludeDatanodes !=3D null) { for (String host : StringUtils .getTrimmedStringCollection(excludeDatanodes)) { int idx =3D host.indexOf(":"); if (idx !=3D -1) {=20 excludes.add(bm.getDatanodeManager().getDatanodeByXferAddr( host.substring(0, idx), Integer.parseInt(host.substring(idx + 1)= ))); } else { excludes.add(bm.getDatanodeManager().getDatanodeByHost(host));//l= ine280 } } } } {code} when datanode(e.g.hadoop2) just crashed before line280, then=C2=A0=C2=A0bm.= getDatanodeManager().getDatanodeByHost(host) will return null, *_excludes_*= containes *{color:#ff0000}null{color}*. while=C2=A0*_excludes_* are used l= ater, NPE happens: {code:java} java.lang.NullPointerException at org.apache.hadoop.net.NodeBase.getPath(NodeBase.java:113) at org.apache.hadoop.net.NetworkTopology.countNumOfAvailableNodes(NetworkTo= pology.java:672) at org.apache.hadoop.net.NetworkTopology.chooseRandom(NetworkTopology.java:= 533) at org.apache.hadoop.net.NetworkTopology.chooseRandom(NetworkTopology.java:= 491) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods.chooseDatanode(NamenodeWebHdfsMethods.java:323) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods.redirectURI(NamenodeWebHdfsMethods.java:384) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods.put(NamenodeWebHdfsMethods.java:652) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods$2.run(NamenodeWebHdfsMethods.java:600) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods$2.run(NamenodeWebHdfsMethods.java:597) at org.apache.hadoop.ipc.ExternalCall.run(ExternalCall.java:73) at org.apache.hadoop.ipc.ExternalCall.run(ExternalCall.java:30) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformatio= n.java:1876) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2830) {code} =C2=A0 was: =C2=A0workload {code:java} curl -i -X PUT -T $HOMEPARH/test.txt "http://hadoop1:9870/webhdfs/v1/input?= op=3DCREATE&excludedatanodes=3Dhadoop2" {code} the method {code:java} org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMethods= .chooseDatanode(String excludeDatanodes){ =C2=A0 =C2=A0 HashSet excludes =3D new HashSet(); if (excludeDatanodes !=3D null) { for (String host : StringUtils .getTrimmedStringCollection(excludeDatanodes)) { int idx =3D host.indexOf(":"); if (idx !=3D -1) {=20 excludes.add(bm.getDatanodeManager().getDatanodeByXferAddr( host.substring(0, idx), Integer.parseInt(host.substring(idx + 1)= ))); } else { excludes.add(bm.getDatanodeManager().getDatanodeByHost(host));//l= ine280 } } } } {code} when host(e.g.hadoop2) just crash before line280, then=C2=A0=C2=A0bm.getDat= anodeManager().getDatanodeByHost(host) will return null, *_excludes_* conta= ines *{color:#ff0000}null{color}*. while=C2=A0*_excludes_* are used later, = NPE happens: {code:java} java.lang.NullPointerException at org.apache.hadoop.net.NodeBase.getPath(NodeBase.java:113) at org.apache.hadoop.net.NetworkTopology.countNumOfAvailableNodes(NetworkTo= pology.java:672) at org.apache.hadoop.net.NetworkTopology.chooseRandom(NetworkTopology.java:= 533) at org.apache.hadoop.net.NetworkTopology.chooseRandom(NetworkTopology.java:= 491) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods.chooseDatanode(NamenodeWebHdfsMethods.java:323) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods.redirectURI(NamenodeWebHdfsMethods.java:384) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods.put(NamenodeWebHdfsMethods.java:652) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods$2.run(NamenodeWebHdfsMethods.java:600) at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMeth= ods$2.run(NamenodeWebHdfsMethods.java:597) at org.apache.hadoop.ipc.ExternalCall.run(ExternalCall.java:73) at org.apache.hadoop.ipc.ExternalCall.run(ExternalCall.java:30) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformatio= n.java:1876) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2830) {code} =C2=A0 > NullPointerException happens in NamenodeWebHdfs > ----------------------------------------------- > > Key: HDFS-14216 > URL: https://issues.apache.org/jira/browse/HDFS-14216 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: lujie > Priority: Critical > Attachments: HDFS-14216_1.patch, hadoop-hires-namenode-hadoop11.l= og > > > =C2=A0workload > {code:java} > curl -i -X PUT -T $HOMEPARH/test.txt "http://hadoop1:9870/webhdfs/v1/inpu= t?op=3DCREATE&excludedatanodes=3Dhadoop2" > {code} > the method > {code:java} > org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMetho= ds.chooseDatanode(String excludeDatanodes){ > =C2=A0 =C2=A0 HashSet excludes =3D new HashSet(); > if (excludeDatanodes !=3D null) { > for (String host : StringUtils > .getTrimmedStringCollection(excludeDatanodes)) { > int idx =3D host.indexOf(":"); > if (idx !=3D -1) {=20 > excludes.add(bm.getDatanodeManager().getDatanodeByXferAddr( > host.substring(0, idx), Integer.parseInt(host.substring(idx + = 1)))); > } else { > excludes.add(bm.getDatanodeManager().getDatanodeByHost(host));/= /line280 > } > } > } > } > {code} > when datanode(e.g.hadoop2) just crashed before line280, then=C2=A0=C2=A0b= m.getDatanodeManager().getDatanodeByHost(host) will return null, *_excludes= _* containes *{color:#ff0000}null{color}*. while=C2=A0*_excludes_* are used= later, NPE happens: > {code:java} > java.lang.NullPointerException > at org.apache.hadoop.net.NodeBase.getPath(NodeBase.java:113) > at org.apache.hadoop.net.NetworkTopology.countNumOfAvailableNodes(Network= Topology.java:672) > at org.apache.hadoop.net.NetworkTopology.chooseRandom(NetworkTopology.jav= a:533) > at org.apache.hadoop.net.NetworkTopology.chooseRandom(NetworkTopology.jav= a:491) > at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMe= thods.chooseDatanode(NamenodeWebHdfsMethods.java:323) > at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMe= thods.redirectURI(NamenodeWebHdfsMethods.java:384) > at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMe= thods.put(NamenodeWebHdfsMethods.java:652) > at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMe= thods$2.run(NamenodeWebHdfsMethods.java:600) > at org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMe= thods$2.run(NamenodeWebHdfsMethods.java:597) > at org.apache.hadoop.ipc.ExternalCall.run(ExternalCall.java:73) > at org.apache.hadoop.ipc.ExternalCall.run(ExternalCall.java:30) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:422) > at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformat= ion.java:1876) > at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2830) > {code} > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org