hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sammi Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-699) Detect Ozone Network topology
Date Mon, 28 Jan 2019 09:11:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753814#comment-16753814
] 

Sammi Chen commented on HDDS-699:
---------------------------------

[~xyao], thanks for your time. 
{quote}
Line 72: do we really want to allow setLevel() explictly or it is for testing only? This may
mess up with the
actual level that is set up via setParent().
{quote}
setLevel is not for testing. Except ROOT node is level  "1", all other nodes need to set their
level explicitly. You can refer to InnerNodeImpl#add for more information.

{quote}
Line 89: does the leafIndex count the excludedNodes?
{quote}
leafIndex doesn't count the excludedNodes, nodes in excludeScope and any nodes involved if
"ancestorGen" is specified. I will add the more comments to the function.

{quote}
InnerNodeImpl.java
Line 295-301: can we document this in the getLeaf() API?
{quote}
Don't get the point well. Can you elaborate it? 

{quote}
Line 102: do we assume case sensitive for the network path and prefix here
{quote}
case insensitive.

The reset will be addressed in later patch. 

> Detect Ozone Network topology
> -----------------------------
>
>                 Key: HDDS-699
>                 URL: https://issues.apache.org/jira/browse/HDDS-699
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Xiaoyu Yao
>            Assignee: Sammi Chen
>            Priority: Major
>         Attachments: HDDS-699.00.patch, HDDS-699.01.patch
>
>
> Traditionally this has been implemented in Hadoop via script or customizable java class.
One thing we want to add here is the flexible multi-level support instead of fixed levels
like DC/Rack/NG/Node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message