From hdfs-issues-return-245075-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Dec 7 07:00:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C84B1180647 for ; Fri, 7 Dec 2018 07:00:07 +0100 (CET) Received: (qmail 87873 invoked by uid 500); 7 Dec 2018 06:00:06 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 87862 invoked by uid 99); 7 Dec 2018 06:00:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2018 06:00:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4CBCCCC273 for ; Fri, 7 Dec 2018 06:00:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id EcqhfbugQoLn for ; Fri, 7 Dec 2018 06:00:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8BED65F612 for ; Fri, 7 Dec 2018 06:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1FCDCE0104 for ; Fri, 7 Dec 2018 06:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 67293252CB for ; Fri, 7 Dec 2018 06:00:00 +0000 (UTC) Date: Fri, 7 Dec 2018 06:00:00 +0000 (UTC) From: "Yiqun Lin (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDDS-99) Adding SCM Audit log MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-99?page=3Dcom.atlassian.ji= ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1671237= 5#comment-16712375 ]=20 Yiqun Lin edited comment on HDDS-99 at 12/7/18 5:59 AM: -------------------------------------------------------- {quote} When I was writing this piece, I initially felt the same. However, I notice= d that even with this new approach we are not really reducing the line coun= t as, no matter what approach we take, we will have to specify the p= air. The only realistic duplicate line is when we initialize an audit map. = Thus, I feel we can write a function to just get an empty map, else I think= we can skip this part because the multiple lines of type auditMap.put("key= ",value) appear to be more readable to me. Let me know what you think. {quote} [~dineshchitlangia], actually here I was intended to reduce lines of {{audi= tMap.put("key",value)}} if there are many parameters. I'm fine if you think= this will look more readable for not changing this. :). =C2=A0 was (Author: linyiqun): {quote} When I was writing this piece, I initially felt the same. However, I notice= d that even with this new approach we are not really reducing the line coun= t as, no matter what approach we take, we will have to specify the p= air. The only realistic duplicate line is when we initialize an audit map. = Thus, I feel we can write a function to just get an empty map, else I think= we can skip this part because the multiple lines of type auditMap.put("key= ",value) appear to be more readable to me. Let me know what you think. {quote} [~dineshchitlangia], actually here I was intended to reduce lines of {{audi= tMap.put("key",value)}} if there are many parameters. I'm fine if you think= this will look more readable. :). =C2=A0 > Adding SCM Audit log > -------------------- > > Key: HDDS-99 > URL: https://issues.apache.org/jira/browse/HDDS-99 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: SCM > Reporter: Xiaoyu Yao > Assignee: Dinesh Chitlangia > Priority: Major > Labels: alpha2 > Attachments: HDDS-99.001.patch > > > This ticket is opened to add SCM audit log. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org