hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-890) Handle OverlappingFileLockException during writeStateMachineData in ContainerStateMachine
Date Sun, 02 Dec 2018 21:07:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706467#comment-16706467
] 

Hadoop QA commented on HDDS-890:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 22s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 2 new or modified test files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 33s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m 14s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m 38s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 45s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 15s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 17m 41s{color}
| {color:green} branch has no errors when building and testing our client artifacts. {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue}
Skipped patched modules with no Java source: hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 55s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 58s{color} |
{color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 25s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 59s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m 46s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 16m 46s{color} | {color:green}
the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  3m 44s{color}
| {color:orange} root: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
{color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 16s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 24s{color}
| {color:green} patch has no errors when building and testing our client artifacts. {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue}
Skipped patched modules with no Java source: hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  7s{color} | {color:red}
hadoop-hdds/container-service generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 56s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  1m  6s{color} | {color:red}
container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  9m 30s{color} | {color:red}
integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 41s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}115m 59s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
|  |  Redundant nullcheck of dispatcherContext, which is known to be non-null in org.apache.hadoop.ozone.container.keyvalue.KeyValueHandler.handlePutSmallFile(ContainerProtos$ContainerCommandRequestProto,
KeyValueContainer, DispatcherContext)  Redundant null check at KeyValueHandler.java:is known
to be non-null in org.apache.hadoop.ozone.container.keyvalue.KeyValueHandler.handlePutSmallFile(ContainerProtos$ContainerCommandRequestProto,
KeyValueContainer, DispatcherContext)  Redundant null check at KeyValueHandler.java:[line
696] |
| Failed junit tests | hadoop.ozone.container.keyvalue.TestKeyValueBlockIterator |
|   | hadoop.ozone.container.common.impl.TestHddsDispatcher |
|   | hadoop.ozone.container.keyvalue.TestBlockManagerImpl |
|   | hadoop.ozone.container.keyvalue.TestKeyValueContainer |
|   | hadoop.ozone.TestOzoneConfigurationFields |
|   | hadoop.ozone.container.common.helpers.TestBlockData |
|   | hadoop.ozone.scm.TestContainerSmallFile |
|   | hadoop.ozone.container.common.TestBlockDeletingService |
|   | hadoop.ozone.web.client.TestKeys |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-890 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12950297/HDDS-890.000.patch
|
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient
 findbugs  checkstyle  |
| uname | Linux 64d839b178c2 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16
UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 042c8ef |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| checkstyle | https://builds.apache.org/job/PreCommit-HDDS-Build/1857/artifact/out/diff-checkstyle-root.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HDDS-Build/1857/artifact/out/new-findbugs-hadoop-hdds_container-service.html
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1857/artifact/out/patch-unit-hadoop-hdds_container-service.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1857/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/1857/testReport/ |
| Max. process+thread count | 3060 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/container-service hadoop-ozone/integration-test U: . |
| Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/1857/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Handle  OverlappingFileLockException during writeStateMachineData in ContainerStateMachine

> -------------------------------------------------------------------------------------------
>
>                 Key: HDDS-890
>                 URL: https://issues.apache.org/jira/browse/HDDS-890
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Datanode
>    Affects Versions: 0.4.0
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>         Attachments: HDDS-890.000.patch
>
>
> With raft log entries getting truncated, the corresponding writeStateMachineData futures
doing actual chunk writes can not aborted. The next subsequent log entry corresponding to
the same client request may end up writing the same chunk file concurrently hittingĀ OverlappingFileLockException.
This Jira aims to address this issue by appending logIndex and term to every tmp chunkFile
name created during writeStateMachineData call,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message