hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fei Hui (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-14114) RBF:MIN_ACTIVE_RATIO should be configurable
Date Mon, 03 Dec 2018 11:11:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Fei Hui updated HDFS-14114:
---------------------------
    Attachment: HDFS-14114.005.patch

> RBF:MIN_ACTIVE_RATIO should be configurable
> -------------------------------------------
>
>                 Key: HDFS-14114
>                 URL: https://issues.apache.org/jira/browse/HDFS-14114
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Fei Hui
>            Assignee: Fei Hui
>            Priority: Major
>         Attachments: HDFS-14114.001.patch, HDFS-14114.002.patch, HDFS-14114.003.patch,
HDFS-14114.004.patch, HDFS-14114.005.patch
>
>
> The following code contains 
> {code:java}
>       if (timeSinceLastActive > connectionCleanupPeriodMs ||
>           active < MIN_ACTIVE_RATIO * total) {
>         // Remove and close 1 connection
>         List<ConnectionContext> conns = pool.removeConnections(1);
>         for (ConnectionContext conn : conns) {
>           conn.close();
>         }
>         LOG.debug("Removed connection {} used {} seconds ago. " +
>                 "Pool has {}/{} connections", pool.getConnectionPoolId(),
>             TimeUnit.MILLISECONDS.toSeconds(timeSinceLastActive),
>             pool.getNumConnections(), pool.getMaxSize());
>       }
> ...
>             if (pool.getNumConnections() < pool.getMaxSize() &&
>                 active >= MIN_ACTIVE_RATIO * total) {
>               ConnectionContext conn = pool.newConnection();
>               pool.addConnection(conn);
>             } else {
>               LOG.debug("Cannot add more than {} connections to {}",
>                   pool.getMaxSize(), pool);
>             }
> {code}
> It affects cleanup and creating Connections. Maybe it should be configurable so that
we can reconfig it to improve performance



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message