hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDDS-99) Adding SCM Audit log
Date Fri, 07 Dec 2018 06:00:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712375#comment-16712375
] 

Yiqun Lin edited comment on HDDS-99 at 12/7/18 5:59 AM:
--------------------------------------------------------

{quote}
When I was writing this piece, I initially felt the same. However, I noticed that even with
this new approach we are not really reducing the line count as, no matter what approach we
take, we will have to specify the <K, V> pair. The only realistic duplicate line is
when we initialize an audit map. Thus, I feel we can write a function to just get an empty
map, else I think we can skip this part because the multiple lines of type auditMap.put("key",value)
appear to be more readable to me. Let me know what you think.
{quote}
[~dineshchitlangia], actually here I was intended to reduce lines of {{auditMap.put("key",value)}}
if there are many parameters. I'm fine if you think this will look more readable for not changing
this. :).
 


was (Author: linyiqun):
{quote}
When I was writing this piece, I initially felt the same. However, I noticed that even with
this new approach we are not really reducing the line count as, no matter what approach we
take, we will have to specify the <K, V> pair. The only realistic duplicate line is
when we initialize an audit map. Thus, I feel we can write a function to just get an empty
map, else I think we can skip this part because the multiple lines of type auditMap.put("key",value)
appear to be more readable to me. Let me know what you think.
{quote}
[~dineshchitlangia], actually here I was intended to reduce lines of {{auditMap.put("key",value)}}
if there are many parameters. I'm fine if you think this will look more readable. :).
 

> Adding SCM Audit log
> --------------------
>
>                 Key: HDDS-99
>                 URL: https://issues.apache.org/jira/browse/HDDS-99
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: SCM
>            Reporter: Xiaoyu Yao
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>              Labels: alpha2
>         Attachments: HDDS-99.001.patch
>
>
> This ticket is opened to add SCM audit log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message