hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (HDFS-13443) RBF: Update mount table cache immediately after changing (add/update/remove) mount table entries.
Date Thu, 06 Dec 2018 17:57:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711794#comment-16711794
] 

Íñigo Goiri commented on HDFS-13443:
------------------------------------

Thanks [~arshad.mohammad] for tackling my comments.
Two minor nits:
* {{MountTableRefresherService#refresh()}}, could use {{else if}} in line 216/217.
* {{MountTableRefresherService#refresh()}} could define the {{RouterClient}} directly in the
line where is used as it is not used outside the try.

The unit tests seem to run fine:
* https://builds.apache.org/job/PreCommit-HDFS-Build/25723/testReport/org.apache.hadoop.hdfs.server.federation.router/TestRouterAdminCLI/
* https://builds.apache.org/job/PreCommit-HDFS-Build/25723/testReport/org.apache.hadoop.hdfs.server.federation.router/TestRouterMountTableCacheRefresh/

+1

Anybody else available to take a look?

> RBF: Update mount table cache immediately after changing (add/update/remove) mount table
entries.
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13443
>                 URL: https://issues.apache.org/jira/browse/HDFS-13443
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Mohammad Arshad
>            Assignee: Mohammad Arshad
>            Priority: Major
>              Labels: RBF
>         Attachments: HDFS-13443-012.patch, HDFS-13443-013.patch, HDFS-13443-014.patch,
HDFS-13443-015.patch, HDFS-13443-branch-2.001.patch, HDFS-13443-branch-2.002.patch, HDFS-13443.001.patch,
HDFS-13443.002.patch, HDFS-13443.003.patch, HDFS-13443.004.patch, HDFS-13443.005.patch, HDFS-13443.006.patch,
HDFS-13443.007.patch, HDFS-13443.008.patch, HDFS-13443.009.patch, HDFS-13443.010.patch, HDFS-13443.011.patch
>
>
> Currently mount table cache is updated periodically, by default cache is updated every
minute. After change in mount table, user operations may still use old mount table. This is
bit wrong.
> To update mount table cache, maybe we can do following
>  * *Add refresh API in MountTableManager which will update mount table cache.*
>  * *When there is a change in mount table entries, router admin server can update its
cache and ask other routers to update their cache*. For example if there are three routers
R1,R2,R3 in a cluster then add mount table entry API, at admin server side, will perform following
sequence of action
>  ## user submit add mount table entry request on R1
>  ## R1 adds the mount table entry in state store
>  ## R1 call refresh API on R2
>  ## R1 calls refresh API on R3
>  ## R1 directly freshest its cache
>  ## Add mount table entry response send back to user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message