From hdfs-issues-return-242807-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Nov 15 12:37:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A51D7180669 for ; Thu, 15 Nov 2018 12:37:03 +0100 (CET) Received: (qmail 64809 invoked by uid 500); 15 Nov 2018 11:37:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 64798 invoked by uid 99); 15 Nov 2018 11:37:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2018 11:37:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1BC72CD3E0 for ; Thu, 15 Nov 2018 11:37:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xJaYft8wH4kL for ; Thu, 15 Nov 2018 11:37:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0A5585FB32 for ; Thu, 15 Nov 2018 11:37:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9B449E0110 for ; Thu, 15 Nov 2018 11:37:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 62BFD21358 for ; Thu, 15 Nov 2018 11:37:00 +0000 (UTC) Date: Thu, 15 Nov 2018 11:37:00 +0000 (UTC) From: "Elek, Marton (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDDS-732) Add read method which takes offset and length in SignedChunkInputStream MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-732?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D166878= 94#comment-16687894 ]=20 Elek, Marton commented on HDDS-732: ----------------------------------- Thanks [~candychencan] to work on this issue. I executed the unit tests and they work well but I have two comments: 1. First of all the read(byte b[], int off, int len) call could be more fas= ter than read() in some cases (depends from the underlying InputStream). If= I understood well the original comment from [~bharatviswa], the goal here = is to use the read(byte[],int,int) on the originalStream in our read(byte[]= ,int,int), which is added in this patch very well. I think it could be done with adjusting the line 82 to the read max(remaini= ngData, currentLen) number of bytes with read(byte[],int,int) 2. The other minor: Even if we will have this excellent read(byte[],int,int= ) some stupid client may use the simple read(). With the modification in th= e unit test we test only the new read method. I would test both of the read= s. > Add read method which takes offset and length in SignedChunkInputStream > ----------------------------------------------------------------------- > > Key: HDDS-732 > URL: https://issues.apache.org/jira/browse/HDDS-732 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Bharat Viswanadham > Assignee: chencan > Priority: Major > Attachments: HDDS-732.001.patch, HDDS-732.002.patch > > > This Jira is created from the comments in=C2=A0HDDS-693 > =C2=A0 > {quote}We have only read(), we don't have read(byte[] b, int off, int len= ), we might see some slow operation during put with SignedInputStream.=C2= =A0=C2=A0 > {quote} > 100% agree. I didn't check any performance numbers, yet, but we need to d= o it sooner or later. I would implement this method in a separate jira as i= t adds more complexity and as of now I would like to support the mkdir oper= ations of the s3a unit tests (where the size is 0). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org