hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jitendra Nath Pandey (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDDS-870) Avoid creating block sized buffer in ChunkGroupOutputStream
Date Sat, 24 Nov 2018 07:55:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697549#comment-16697549
] 

Jitendra Nath Pandey edited comment on HDDS-870 at 11/24/18 7:54 AM:
---------------------------------------------------------------------

I took a quick look at the patch. Instead of tracking {{lastFlushIndex}}, it may be easier
to track an {{AtomicReference}} to the entry in the buffer-list.

{{totalSuccessfulFlushedData}} might run into GBs (for larger block sizes) and overflow an
integer. Let's use {{long}} for this.


was (Author: jnp):
I took a quick look at the patch. Instead of tracking {{lastFlushIndex}}, it may be easier
to track an {{AtomicReference}} to the entry in the buffer-list.

> Avoid creating block sized buffer in ChunkGroupOutputStream
> -----------------------------------------------------------
>
>                 Key: HDDS-870
>                 URL: https://issues.apache.org/jira/browse/HDDS-870
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Client
>    Affects Versions: 0.4.0
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>             Fix For: 0.4.0
>
>         Attachments: HDDS-870.000.patch
>
>
> Currently, for a key, we create a block size byteBuffer in order for caching data. This
can be replaced with an array of buffers of size flush buffer size configured for handling
2 node failures as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message