hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ayush Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14085) RBF: LS command for root shows wrong owner and permission information.
Date Tue, 27 Nov 2018 18:37:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700846#comment-16700846
] 

Ayush Saxena commented on HDFS-14085:
-------------------------------------

Thanks [~elgoiri] for the review!!!
{quote}I think we could have an After method to cleanup instead of having to do the finally.
{quote}
I too had this same intent but there is one problem going this way that firstly name and number
of files is different in the tests and moreover one test I guess doesn't create even.We can't
explicitly delete with the name because if that file was not created in the test it will fetch
us an FileNotFoundException. The only way to do this call Ls on root of both the Namespace
and iterate throughout to check if there is a file then delete.I did it but it little more
time taking thats why I came back to this approach.No doubt we can go for putting it in the
After method.If you confirm.
{quote}We were going through that part of the code and we were able to list the paths with
no issues?
{quote}
If I am getting your concern correctly.You are confirming that Are we covering the part where
"/" was removed? If that is the question then Yes.All the Tests are going through the same
path which removes the "/" .

Actually the getMountPointStatus() where actually this processing is happening is called up
by two methods one is the getListing() which is used here which removes the "/" and second
by getFileInfo() which keeps it. In the previous test getFileInfo() was used that is why no
discrepancy or error was not encountered .

I will upload the next patch with fixed checkstyle, Once confirmed regarding the After method
approach :)

> RBF: LS command for root shows wrong owner and permission information.
> ----------------------------------------------------------------------
>
>                 Key: HDFS-14085
>                 URL: https://issues.apache.org/jira/browse/HDFS-14085
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14085-HDFS-13891-01.patch, HDFS-14085-HDFS-13891-02.patch
>
>
> The LS command for / lists all the mount entries but the permission displayed is the
default permission (777) and the owner and group info same as that of the user calling it;
Which actually should be the same as that of the destination of the mount point.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message