hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kitti Nanasi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14064) WEBHDFS: Support Enable/Disable EC Policy
Date Mon, 12 Nov 2018 11:19:01 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683591#comment-16683591
] 

Kitti Nanasi commented on HDFS-14064:
-------------------------------------

Thanks [~ayushtkn] for working on this!
The code looks good to me, I just have minor comments about the tests:
- I think the IOException shouldn't be caught in the tests, because it is not expected and
it will hide actual errors.
- The test case should fail if the policy is not found instead of silently succeeding
- I would do an assertion after the disablePolicy to make sure that we are really running
the test on a disabled policy. For example if the default policy couldn't be disabled (which
is not true currently), the enable policy test would succeed, but wouldn't really test anything.





> WEBHDFS: Support Enable/Disable EC Policy
> -----------------------------------------
>
>                 Key: HDFS-14064
>                 URL: https://issues.apache.org/jira/browse/HDFS-14064
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14064-01.patch, HDFS-14064-02.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message