hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-825) Code cleanup based on messages from ErrorProne
Date Fri, 16 Nov 2018 03:58:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688998#comment-16688998
] 

Hadoop QA commented on HDDS-825:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 19s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 56 new or modified test files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  8m  1s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m 58s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m 36s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 17s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  8m 39s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 23m 31s{color}
| {color:green} branch has no errors when building and testing our client artifacts. {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue}
Skipped patched modules with no Java source: hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  9m 16s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  5m 30s{color} |
{color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 25s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 50s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m 24s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m 24s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m  2s{color}
| {color:green} root: The patch generated 0 new + 0 unchanged - 19 fixed = 0 total (was 19)
{color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  6m 43s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 15s{color}
| {color:green} patch has no errors when building and testing our client artifacts. {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue}
Skipped patched modules with no Java source: hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 10m 20s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m 53s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 38s{color} | {color:red}
common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 35s{color} | {color:red}
framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 41s{color} | {color:red}
container-service in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 34s{color} | {color:green}
client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 41s{color} | {color:red}
server-scm in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 40s{color} | {color:red}
common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 37s{color} | {color:red}
client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 38s{color} | {color:red}
ozone-manager in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 36s{color} | {color:red}
objectstore-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 39s{color} | {color:red}
s3gateway in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 40s{color} | {color:red}
integration-test in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 39s{color} | {color:red}
ozonefs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 40s{color} | {color:red}
tools in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 46s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}158m 18s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-825 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12948422/HDDS-825.005.patch
|
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient
 findbugs  checkstyle  |
| uname | Linux b64c81e065d8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / fcd94ee |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-hdds_common.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-hdds_framework.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-hdds_container-service.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-ozone_common.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-ozone_client.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-ozone_objectstore-service.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-ozone_s3gateway.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-ozone_ozonefs.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/artifact/out/patch-unit-hadoop-ozone_tools.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/testReport/ |
| Max. process+thread count | 412 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/common hadoop-hdds/framework hadoop-hdds/container-service hadoop-hdds/client
hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager
hadoop-ozone/objectstore-service hadoop-ozone/s3gateway hadoop-ozone/integration-test hadoop-ozone/ozonefs
hadoop-ozone/tools U: . |
| Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/1736/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Code cleanup based on messages from ErrorProne
> ----------------------------------------------
>
>                 Key: HDDS-825
>                 URL: https://issues.apache.org/jira/browse/HDDS-825
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>            Priority: Major
>             Fix For: 0.4.0
>
>         Attachments: HDDS-825.001.patch, HDDS-825.002.patch, HDDS-825.003.patch, HDDS-825.004.patch,
HDDS-825.005.patch
>
>
> I ran ErrorProne (http://errorprone.info/) on Ozone/HDDS code base and it threw lots
of errors. This patch fixes many issues pointed out by ErrorProne.
> The main classes of errors fixed in this patch are:
> * http://errorprone.info/bugpattern/DefaultCharset
> * http://errorprone.info/bugpattern/ComparableType
> * http://errorprone.info/bugpattern/StringSplitter
> * http://errorprone.info/bugpattern/IntLongMath
> * http://errorprone.info/bugpattern/JavaLangClash
> * http://errorprone.info/bugpattern/CatchFail
> * http://errorprone.info/bugpattern/JdkObsolete
> * http://errorprone.info/bugpattern/AssertEqualsArgumentOrderChecker
> * http://errorprone.info/bugpattern/CatchAndPrintStackTrace
> It is pretty educative to read through these errors and see the mistakes we made.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message