hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-820) Use more strict data format for the Last-Modified headers of s3 gateway
Date Fri, 09 Nov 2018 14:43:01 GMT

    [ https://issues.apache.org/jira/browse/HDDS-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681526#comment-16681526
] 

Hadoop QA commented on HDDS-820:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 16s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 2 new or modified test files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m  2s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 28s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 17s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 28s{color} |
{color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 11m 44s{color} | {color:red}
branch has errors when building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 35s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 23s{color} |
{color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 28s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 23s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 23s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 13s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 25s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 12m  6s{color} | {color:red}
patch has errors when building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 40s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 20s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 28s{color} | {color:red}
s3gateway in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 28s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 20s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-820 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12947580/HDDS-820.002.patch
|
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient
 findbugs  checkstyle  |
| uname | Linux b1b18df43d98 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 9dbb2b6 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1658/artifact/out/patch-unit-hadoop-ozone_s3gateway.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/1658/testReport/ |
| Max. process+thread count | 94 (vs. ulimit of 10000) |
| modules | C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway |
| Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/1658/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Use more strict data format for the Last-Modified headers of s3 gateway
> -----------------------------------------------------------------------
>
>                 Key: HDDS-820
>                 URL: https://issues.apache.org/jira/browse/HDDS-820
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: S3
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>             Fix For: 0.4.0
>
>         Attachments: HDDS-820.001.patch, HDDS-820.002.patch
>
>
> The format of HTTP Last-Modified header is defined by rfc-1123 (which updates the earlier
rfc-822)
> From https://tools.ietf.org/html/rfc1123
> {code}
>    5.2.14  RFC-822 Date and Time Specification: RFC-822 Section 5
>          The syntax for the date is hereby changed to:
>             date = 1*2DIGIT month 2*4DIGIT
> {code}
> From https://tools.ietf.org/html/rfc822
> {code}
>  2.4.  *RULE:  REPETITION
>      
>           The character "*" preceding an element indicates repetition.
>      The full form is:
>      
>                               <l>*<m>element
>      
>      indicating at least <l> and at most <m> occurrences  of  element.
>      Default values are 0 and infinity so that "*(element)" allows any
>      number, including zero; "1*element" requires at  least  one;  and
>      "1*2element" allows one or two.
> {code}
> It means that both of the following dates are good:
> * Wed, 07 Nov 2018 10:31:05 GMT (two digits day)
> * Wed, 7 Nov 2018 10:31:05 GMT (one digits day)
> Java implements it in the right way in DateTimeFormatter.RFC_1123_DATE_TIME, it sets
the minimum and maximum size of the day field (1-2)
> Golang follows a different way to define the date format, there is a fixed date which
should be used as an example format which will be followed.
> http.TimeFormat (in golang) defines the format of the HTTP date:
> From https://golang.org/src/time/format.go
> {code}
> 	RFC1123     = "Mon, 02 Jan 2006 15:04:05 MST"
> {code}
> Base on this definition the day also should be two digits.
> *Summary*: As rfc1123 allows the usage of both format I propose two use the two digit
days all the time, to make it possible to use the s3g from golang.
> Note: this is required as the CTrox/csi-s3 driver uses the golang base minio s3 client
to create/get/list buckets before mounting it with fuse drivers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message