hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (HDFS-14006) Refactor name node to allow different token verification implementations
Date Wed, 21 Nov 2018 17:23:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694976#comment-16694976
] 

Íñigo Goiri commented on HDFS-14006:
------------------------------------

{code}
public static TokenVerifier getTokenVerifierFromContext(ServletContext context) {
  return (TokenVerifier) context.getAttribute(NAMENODE_ATTRIBUTE_KEY);
}
{code}
Shows the {{TokenVerifier}} raw but this uses {{T}} and we use it as {{TokenVerifier<DelegationTokenIdentifier>}}.
Not sure how to manage those raw types.

A minor comment, should we add the {{Override}} annotation in {{NameNode#verifyToken()}}?

In any case, I think adding {{TokenVerifier}} is cleaner than what we had before.

> Refactor name node to allow different token verification implementations
> ------------------------------------------------------------------------
>
>                 Key: HDFS-14006
>                 URL: https://issues.apache.org/jira/browse/HDFS-14006
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: CR Hota
>            Assignee: CR Hota
>            Priority: Major
>         Attachments: HDFS-14006.001.patch, HDFS-14006.002.patch
>
>
> Router currently uses Namenode web resources to read and verify delegation tokens. This
model doesn't work when router will be deployed in secured mode. This change will introduce
router's own UserProvider resource and dependencies.
> In the current deployment one can see this exception.
> {"RemoteException":\{"exception":"ClassCastException","javaClassName":"java.lang.ClassCastException","message":"org.apache.hadoop.hdfs.server.federation.router.Router
cannot be cast to org.apache.hadoop.hdfs.server.namenode.NameNode"}}
> In the proposed change, router will maintain its own web resource, that will be similar
to current namenode, but modified to get back a router instance instead of namenode.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message