From hdfs-issues-return-237229-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Oct 9 21:49:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 06C5718067A for ; Tue, 9 Oct 2018 21:49:03 +0200 (CEST) Received: (qmail 13220 invoked by uid 500); 9 Oct 2018 19:49:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 13201 invoked by uid 99); 9 Oct 2018 19:49:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2018 19:49:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9EB181A01C9 for ; Tue, 9 Oct 2018 19:49:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id fnp_hq7Fk-1x for ; Tue, 9 Oct 2018 19:49:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 298645F3EE for ; Tue, 9 Oct 2018 19:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 72203E0D27 for ; Tue, 9 Oct 2018 19:49:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 35504247FD for ; Tue, 9 Oct 2018 19:49:00 +0000 (UTC) Date: Tue, 9 Oct 2018 19:49:00 +0000 (UTC) From: "Bharat Viswanadham (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDDS-585) Handle common request identifiers in a transparent way MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644008#comment-16644008 ] Bharat Viswanadham commented on HDDS-585: ----------------------------------------- I have committed this to the trunk and ozone-0.3 branch. > Handle common request identifiers in a transparent way > ------------------------------------------------------ > > Key: HDDS-585 > URL: https://issues.apache.org/jira/browse/HDDS-585 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Fix For: 0.3.0, 0.4.0 > > Attachments: HDDS-585.001.patch, HDDS-585.003.patch, HDDS-585.004.patch > > > As of now multiple endpoint contains the code to handle the amazon specific request id-s. > {code} > setRequestId(OzoneUtils.getRequestID()); > ... > return Response.ok().status(HttpStatus.SC_NO_CONTENT).header( > "x-amz-request-id", getRequestId()).header("x-amz-id-2", > RandomStringUtils.randomAlphanumeric(8, 16)).build(); > {code} > I propose to handle the request id generation + adding it to the headers in one location which is transparent for all the rest endpoints. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org