From hdfs-issues-return-236792-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Oct 8 12:14:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 38BC3180652 for ; Mon, 8 Oct 2018 12:14:03 +0200 (CEST) Received: (qmail 93659 invoked by uid 500); 8 Oct 2018 10:14:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 93646 invoked by uid 99); 8 Oct 2018 10:14:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Oct 2018 10:14:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D8F30C0158 for ; Mon, 8 Oct 2018 10:14:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id rC9Bw-rG0C8t for ; Mon, 8 Oct 2018 10:14:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1A3755F39E for ; Mon, 8 Oct 2018 10:14:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B487DE0E87 for ; Mon, 8 Oct 2018 10:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7C014247DB for ; Mon, 8 Oct 2018 10:14:00 +0000 (UTC) Date: Mon, 8 Oct 2018 10:14:00 +0000 (UTC) From: "Surendra Singh Lilhore (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDFS-13962) Add null check for add-replica pool to avoid lock acquiring MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641620#comment-16641620 ] Surendra Singh Lilhore edited comment on HDFS-13962 at 10/8/18 10:13 AM: ------------------------------------------------------------------------- Attached v1 patch. please review.. was (Author: surendrasingh): Attached V1 patch. please review.. > Add null check for add-replica pool to avoid lock acquiring > ----------------------------------------------------------- > > Key: HDFS-13962 > URL: https://issues.apache.org/jira/browse/HDFS-13962 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 3.1.1 > Reporter: Yiqun Lin > Assignee: Surendra Singh Lilhore > Priority: Major > Attachments: HDFS-13962.01.patch > > > This is a follow-up work for HDFS-13768. Mainly two places needed to update: > * Add null check for add-replica pool to avoid lock acquiring > * In {{ReplicaMap#addAndGet}}, it would be better to use {{FoldedTreeSet#addOrReplace}} instead of {{FoldedTreeSet#add}} for adding replica info. This is for the logic consistentency with add operation -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org