hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elek, Marton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-743) S3 multi delete request should return XML header in quiet mode
Date Mon, 29 Oct 2018 14:45:01 GMT

    [ https://issues.apache.org/jira/browse/HDDS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667299#comment-16667299

Elek, Marton commented on HDDS-743:

Thanks [~bharatviswa]. I didn't notice it, yet.

I checked what is this standalone=yes, and it seems to be more safe to have it. With different
namespace the XML is different (as written in standards). With standalone=yes it's exactly
the same and I don't no and client side tool which could notice the difference.

It could be turned off with a jaxb [property|https://stackoverflow.com/questions/277996/remove-standalone-yes-from-generated-xml],
but it requires a custom marshaller for all of our types.

I would keep it as is until we see a real exception from any of the tested clients.

BTW, it's independent from this patch as the response type is not modified.

> S3 multi delete request should return XML header in quiet mode
> --------------------------------------------------------------
>                 Key: HDDS-743
>                 URL: https://issues.apache.org/jira/browse/HDDS-743
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: S3
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>         Attachments: HDDS-743.001.patch
> Delete multiple objects with sending XML message to the bucket?delete endpoint is implemented
in HDDS-701 according to the aws documentation at [https://docs.aws.amazon.com/AmazonS3/latest/API/multiobjectdeleteapi.html]
> As the documentations writes:
> {quote}{{ By default, the operation uses verbose mode in which the response includes
the result of deletion of each key in your request. In quiet mode the response includes only
keys where the delete operation encountered an error}}
> {quote}
> In the quiet mode (which is an XML element in the input body) we return the XML only
in case of errors based on this paragraph. Without any error we returned **with *empty body*.
> But during the executions of s3a unit tests I found that the right response is an empty
XML document instead of empty body (in case of quiet mode + without any error)
> {code:java}
> <?xml version="1.0" encoding="UTF-8"?>
> <DeleteResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/">{code}
> Some of the s3a unit tests are failed as without XML response the parsing was unsuccessful.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message