hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukas Majercak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14010) Pass correct DF usage to ReservedSpaceCalculator builder
Date Fri, 19 Oct 2018 20:03:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657347#comment-16657347
] 

Lukas Majercak commented on HDFS-14010:
---------------------------------------

002.patch LGTM. Maybe some warn log when usage==null, and a comment for the unit test.

> Pass correct DF usage to ReservedSpaceCalculator builder
> --------------------------------------------------------
>
>                 Key: HDFS-14010
>                 URL: https://issues.apache.org/jira/browse/HDFS-14010
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.9.2
>            Reporter: Lukas Majercak
>            Assignee: Lukas Majercak
>            Priority: Minor
>         Attachments: HDFS-14010.001.patch, HDFS-14010.002.patch
>
>
> In FsVolumeImpl's constructor, we currently pass the DF usage that was passed to the
constructor to ReservedSpaceCalculator.Builder. This can cause issues if the usage is changed
in the constructor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message