hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDDS-528) add cli command to checkChill mode status and exit chill mode
Date Fri, 26 Oct 2018 03:25:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664599#comment-16664599
] 

Yiqun Lin edited comment on HDDS-528 at 10/26/18 3:24 AM:
----------------------------------------------------------

Hi [~candychencan], some minor review comments from me:

* Can we use consistent name for chill mode? Some places we use {{Chill mode}}, some are {{chill
mode}}. I suppose {{chill mode}} should be the right one.
{noformat}
+  /**
+   * Check if SCM is in chill mode.
+   *
+   * @return Returns true if SCM is in chill mode else returns false.
+   * @throws IOException
+   */
+  .....
+
+  /**
+   * Force SCM out of Chill mode.
{noformat}

Also please take care of the checkstyle warnings, looks like there are some unused imports
and redundant modifiers.


was (Author: linyiqun):
Hi [~candychencan], some minor review comments from me:

* Can we use consistent name for chill mode? Some places we use {{Chill mode}}, some are {{chill
mode}}.
{noformat}
+  /**
+   * Check if SCM is in chill mode.
+   *
+   * @return Returns true if SCM is in chill mode else returns false.
+   * @throws IOException
+   */
+  .....
+
+  /**
+   * Force SCM out of Chill mode.
{noformat}

Also please take care of the checkstyle warnings, looks like there are some unused imports
and redundant modifiers.

> add cli command to checkChill mode status and exit chill mode
> -------------------------------------------------------------
>
>                 Key: HDDS-528
>                 URL: https://issues.apache.org/jira/browse/HDDS-528
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Ajay Kumar
>            Assignee: chencan
>            Priority: Major
>         Attachments: HDDS-528.001.patch, HDDS-528.002.patch, HDDS-528.003.patch
>
>
> [HDDS-370] introduces below 2 API:
> * isScmInChillMode
> * forceScmExitChillMode
> This jira is to call them via relevant cli command.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message