hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-361) Use DBStore and TableStore for DN metadata
Date Sun, 28 Oct 2018 17:05:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666475#comment-16666475

Anu Engineer commented on HDDS-361:

Thank you for updating the patch. I had to rebase to the trunk to review. Some very minor
comments below.

 ** Execute delete transaction for every entry in the pending delete table.
while (iter.hasNext())}

 ** Should we have a maximum delete per run, say 1000 delete Tx per call?
Surely I am missing something here, could you please explain to me why we need to do this?
** deleteTxnFilter.accept(keyValue.getKey())

 ** nit: Would it be possible to keep track of how many bytes are deleted too, say via chunk
delete calls? or the block info itself?
** numBlocksDeleted += delTxn.getLocalIDCount()

 ** Do we have to update the BCSID after each delete?

 * The Change in BlockIterator.java is spurious.
 * Nit: DeleteBlocksCommandhanlder.java: segregateTxnByContainerID – Shouldn't this be already
done at the SCM layer?
 * Nit: KeyValueContainerUtil.java: Line 178: Remove the commented out code block?


> Use DBStore and TableStore for DN metadata
> ------------------------------------------
>                 Key: HDDS-361
>                 URL: https://issues.apache.org/jira/browse/HDDS-361
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Xiaoyu Yao
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: HDDS-361.001.patch, HDDS-361.002.patch, HDDS-361.003.patch
> As part of OM performance improvement we used Tables for storing a particular type of
key value pair in the rocks db. This Jira aims to use Tables for separating block keys and
deletion transactions in the container db.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message