From hdfs-issues-return-235201-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Sep 20 23:53:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6994E180679 for ; Thu, 20 Sep 2018 23:53:05 +0200 (CEST) Received: (qmail 33762 invoked by uid 500); 20 Sep 2018 21:53:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 33559 invoked by uid 99); 20 Sep 2018 21:53:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Sep 2018 21:53:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E334B1864CA for ; Thu, 20 Sep 2018 21:53:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id lRZlJOrGxL7A for ; Thu, 20 Sep 2018 21:53:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C62525F533 for ; Thu, 20 Sep 2018 21:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E1724E25AA for ; Thu, 20 Sep 2018 21:53:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7E31923FA8 for ; Thu, 20 Sep 2018 21:53:00 +0000 (UTC) Date: Thu, 20 Sep 2018 21:53:00 +0000 (UTC) From: "Bharat Viswanadham (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDDS-447) separate ozone-dist and hadoop-dist projects with real classpath separation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-447?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D166227= 61#comment-16622761 ]=20 Bharat Viswanadham commented on HDDS-447: ----------------------------------------- Thank You, [~elek] for the patch.=C2=A0 I am able to compile now.=C2=A0 Few changes, I have not understood why it is done. {quote}The classpath of 'ozone fs' is solved in a more easy way. I just add= ed the ozonefs project as a dependency to the tools. Now the classpath of t= he tools project could be used for all the tools (ozone scmcli, ozone fs, .= ..). But it introduced a circular dependency. I fixed it with moving 4 test= classes to the tools. (which also helped to get the classes and the test c= lasses in the same projects). {quote} 1. Why the above mentioned change is needed and why moving the test files i= s done? 2. Now, we don't have a separate folder for each project like hdds,ozone=C2= =A0in ozone tar ball. We have all tozone-related=C2=A0jars in=C2=A0share/oz= one, but for each component, as we have generated classpath, during running= that component, we use only jars needed for that component, by adding only= the jars required for that component from the generated classpath file? 3. And=C2=A0do we need empty folder share/hadoop/ozone and share/hadoop/hdd= s?=C2=A0 =C2=A0 =C2=A0 > separate ozone-dist and hadoop-dist projects with real classpath separati= on > -------------------------------------------------------------------------= -- > > Key: HDDS-447 > URL: https://issues.apache.org/jira/browse/HDDS-447 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Attachments: HDDS-447-ozone-0.2.001.patch, HDDS-447.003.patch, HD= DS-447.004.patch, HDDS-447.005.patch > > > Currently we have the same hadoop-dist project to create both the ozone a= nd and the hadoop distribution. > To decouple ozone and hadoop build it would be great to create two differ= ent dist project. > The hadoop-dist should be cloned to hadoop-ozone/dist and from hadoop-dis= t/pom.xml we can remove the hdds/ozone related items and from hadoop-ozone/= dist/pom.xml we can remove the core hadoop related part. > An other issue with the current distribution schema is the lack of real c= lasspath separation.=20 > The current hadoop distribution model is defined in the hadoop-project-di= st which is parent of all the component projects and the output of the dist= ribution generation will be copied by the dist-layout-stitching. There is n= o easy way to use command specific classpath as the classpath is defined in= component level (hdfs/yarn/mapreduce). > With this approach we will have a lot of unnecessary dependencies on the = classpath (which were not on the classpath at the time of the unit tests) a= nd it's not possible (as an example) use different type of jaxrs stack for = different services (s3gateway vs scm). > As a simplified but more effective approach I propose to use the followin= g method: > 1. don't use hadoop-project-dist for ozone projects any more > 2. During the build generate a classpath descriptor (with the dependency:= build-classpath maven plugin/goal) for all the projects > 3. During the distribution copy all the required dependencies (with depen= dency:copy maven plugin/goal) to a lib folder (share/ozone/lib) > 4. During the distribution copy all the classpath descriptors to the clas= spath folder (share/ozone/classpath) > 5. Put only the required jar files to the classpath with reading the clas= spath descriptor=20 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org