From hdfs-issues-return-233307-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Sep 12 10:11:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5B0EB180630 for ; Wed, 12 Sep 2018 10:11:04 +0200 (CEST) Received: (qmail 37400 invoked by uid 500); 12 Sep 2018 08:11:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 37389 invoked by uid 99); 12 Sep 2018 08:11:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Sep 2018 08:11:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8E19D186915 for ; Wed, 12 Sep 2018 08:11:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id cRXI0XLyu0fI for ; Wed, 12 Sep 2018 08:11:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 35BCA5F4E7 for ; Wed, 12 Sep 2018 08:11:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7A35EE0F4C for ; Wed, 12 Sep 2018 08:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2232724693 for ; Wed, 12 Sep 2018 08:11:00 +0000 (UTC) Date: Wed, 12 Sep 2018 08:11:00 +0000 (UTC) From: "Nanda kumar (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDDS-428) OzoneManager lock optimization MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611735#comment-16611735 ] Nanda kumar commented on HDDS-428: ---------------------------------- Thanks [~anu] for the review. Addressed the comments in patch v01. {quote}ActiveLock#resetCounter {quote} Done {quote}Should we also hold volumeLock? {quote} While deleting a bucket, we never touch {{volume table}}, I don't see why we should acquire a volume lock as it doesn't change or do anything to the volume table. {quote}Looks like we are holding volume lock? do we need this ? {quote} Removed {quote}KeyManagerImpl#allocateBlock {quote} Unless there is a rogue client which calls {{addBlock}} from multiple threads at the same time, we don't need this lock. In such cases, the client will be in much more trouble. I don't think we should handle those cases. Removed the lock from {{KeyManagerImpl#allocateBlock}} > OzoneManager lock optimization > ------------------------------ > > Key: HDDS-428 > URL: https://issues.apache.org/jira/browse/HDDS-428 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: OM > Reporter: Nanda kumar > Assignee: Nanda kumar > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-428.000.patch, HDDS-428.001.patch > > > Currently, {{OzoneManager}} uses a single lock for everything which impacts the performance. We can introduce a separate lock for each resource like User/Volume/Bucket which will give us a performance boost. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org