From hdfs-issues-return-232763-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Sat Sep 8 00:18:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1843C180672 for ; Sat, 8 Sep 2018 00:18:02 +0200 (CEST) Received: (qmail 93720 invoked by uid 500); 7 Sep 2018 22:18:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 93708 invoked by uid 99); 7 Sep 2018 22:18:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Sep 2018 22:18:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A2EFF18B19D for ; Fri, 7 Sep 2018 22:18:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id nFUbO6LkI78u for ; Fri, 7 Sep 2018 22:18:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CB49D5F27E for ; Fri, 7 Sep 2018 22:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 65EB7E006D for ; Fri, 7 Sep 2018 22:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0784E2183D for ; Fri, 7 Sep 2018 22:18:00 +0000 (UTC) Date: Fri, 7 Sep 2018 22:18:00 +0000 (UTC) From: "Chao Sun (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13898?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao Sun reassigned HDFS-13898: ------------------------------- Assignee: Chao Sun > Throw retriable exception for getBlockLocations when ObserverNameNode is = in safemode > -------------------------------------------------------------------------= ----------- > > Key: HDFS-13898 > URL: https://issues.apache.org/jira/browse/HDFS-13898 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Chao Sun > Assignee: Chao Sun > Priority: Major > > When ObserverNameNode is in safe mode, {{getBlockLocations}} may throw sa= fe mode exception if the given file doesn't have any block yet.=C2=A0 > {code} > try { > checkOperation(OperationCategory.READ); > res =3D FSDirStatAndListingOp.getBlockLocations( > dir, pc, srcArg, offset, length, true); > if (isInSafeMode()) { > for (LocatedBlock b : res.blocks.getLocatedBlocks()) { > // if safemode & no block locations yet then throw safemodeExce= ption > if ((b.getLocations() =3D=3D null) || (b.getLocations().length = =3D=3D 0)) { > SafeModeException se =3D newSafemodeException( > "Zero blocklocations for " + srcArg); > if (haEnabled && haContext !=3D null && > haContext.getState().getServiceState() =3D=3D HAServiceSt= ate.ACTIVE) { > throw new RetriableException(se); > } else { > throw se; > } > } > } > } > {code} > It only throws {{RetriableException}} for active NN so requests on observ= er may just fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org