hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13893) DiskBalancer: no validations for Disk balancer commands
Date Thu, 20 Sep 2018 18:59:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622527#comment-16622527
] 

Arpit Agarwal commented on HDFS-13893:
--------------------------------------

Thanks for this improvement [~ljain].

A more robust fix may be to look for unrecognized options in the returned {{CommandLine}}
object via {{CommandLine.getArgs}}.

{code}
    /** 
     * Retrieve any left-over non-recognized options and arguments
     *
     * @return remaining items passed in but not parsed as an array
     */
    public String[] getArgs()
{code}



> DiskBalancer: no validations for Disk balancer commands 
> --------------------------------------------------------
>
>                 Key: HDFS-13893
>                 URL: https://issues.apache.org/jira/browse/HDFS-13893
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: diskbalancer
>            Reporter: Harshakiran Reddy
>            Assignee: Lokesh Jain
>            Priority: Major
>              Labels: newbie
>         Attachments: HDFS-13893.001.patch
>
>
> {{Scenario:-}}
>  
>  1 Run the Disk Balancer commands with extra arguments passing  
> {noformat} 
> hadoopclient> hdfs diskbalancer -plan hostname --thresholdPercentage 2 *sgfsdgfs*
> 2018-08-31 14:57:35,454 INFO planner.GreedyPlanner: Starting plan for Node : hostname:50077
> 2018-08-31 14:57:35,457 INFO planner.GreedyPlanner: Disk Volume set fb67f00c-e333-4f38-a3a6-846a30d4205a
Type : DISK plan completed.
> 2018-08-31 14:57:35,457 INFO planner.GreedyPlanner: Compute Plan for Node : hostname:50077
took 23 ms
> 2018-08-31 14:57:35,457 INFO command.Command: Writing plan to:
> 2018-08-31 14:57:35,457 INFO command.Command: /system/diskbalancer/2018-Aug-31-14-57-35/hostname.plan.json
> Writing plan to:
> /system/diskbalancer/2018-Aug-31-14-57-35/hostname.plan.json
> {noformat} 
> Expected Output:- 
> =============
> Disk balancer commands should be fail if we pass any invalid arguments or extra arguments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message