hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-351) Add chill mode state to SCM
Date Thu, 06 Sep 2018 16:33:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606046#comment-16606046
] 

Anu Engineer commented on HDDS-351:
-----------------------------------

3 out of 5 are trivial to fix and not something that we ignore. If it is not a big bother,
can you please fix these too.
 * HddsTestUtils.java:43: createNodeRegistrationContainerReport(int numOfContainers) {: 'createNodeRegistrationContainerReport'
has incorrect indentation level 2, expected level should be 6. [Indentation]
 *  HddsTestUtils.java:56: createNodeRegistrationContainerReport(List<ContainerInfo>
dnContainers) {: 'createNodeRegistrationContainerReport' has incorrect indentation level 2,
expected level should be 6. [Indentation] .
 * TestSCMChillModeManager.java:37:public class TestSCMChillModeManager {: Missing a Javadoc
comment. [JavadocType]

And probably you can make this variable private since it is not used by anyone else.
 * MiniOzoneCluster.java:212: protected boolean startDataNodes 

Let us ignore the hides field warning, but rest we do fix in regular patches.

 

> Add chill mode state to SCM
> ---------------------------
>
>                 Key: HDDS-351
>                 URL: https://issues.apache.org/jira/browse/HDDS-351
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-351.00.patch, HDDS-351.01.patch, HDDS-351.02.patch, HDDS-351.03.patch,
HDDS-351.04.patch, HDDS-351.05.patch, HDDS-351.06.patch, HDDS-351.07.patch, HDDS-351.08.patch,
HDDS-351.09.patch
>
>
> Add chill mode state to SCM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message