From hdfs-issues-return-231362-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Aug 29 09:47:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1E88B180657 for ; Wed, 29 Aug 2018 09:47:08 +0200 (CEST) Received: (qmail 87721 invoked by uid 500); 29 Aug 2018 07:47:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 87489 invoked by uid 99); 29 Aug 2018 07:47:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2018 07:47:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8A278C025B for ; Wed, 29 Aug 2018 07:47:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id PCnHSvmKRPdB for ; Wed, 29 Aug 2018 07:47:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 556145F3FF for ; Wed, 29 Aug 2018 07:47:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 966C3E0DAA for ; Wed, 29 Aug 2018 07:47:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 56C0B26B58 for ; Wed, 29 Aug 2018 07:47:00 +0000 (UTC) Date: Wed, 29 Aug 2018 07:47:00 +0000 (UTC) From: "Yiqun Lin (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDFS-13863) FsDatasetImpl should log DiskOutOfSpaceException MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596047#comment-16596047 ] Yiqun Lin edited comment on HDFS-13863 at 8/29/18 7:46 AM: ----------------------------------------------------------- LGTM, +1. Hold off the commit to let [~arpitagarwal] to have a look. was (Author: linyiqun): LGMT, +1. Hold off the commit to let [~arpitagarwal] to have a look. > FsDatasetImpl should log DiskOutOfSpaceException > ------------------------------------------------ > > Key: HDFS-13863 > URL: https://issues.apache.org/jira/browse/HDFS-13863 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 3.1.0, 2.9.1, 3.0.3 > Reporter: Fei Hui > Assignee: Fei Hui > Priority: Major > Attachments: HDFS-13863.001.patch, HDFS-13863.002.patch, HDFS-13863.003.patch > > > The code in function *createRbw* as follow > {code:java} > try { > // First try to place the block on a transient volume. > ref = volumes.getNextTransientVolume(b.getNumBytes()); > datanode.getMetrics().incrRamDiskBlocksWrite(); > } catch (DiskOutOfSpaceException de) { > // Ignore the exception since we just fall back to persistent storage. > } finally { > if (ref == null) { > cacheManager.release(b.getNumBytes()); > } > } > {code} > I think we should log the exception because it took me long time to resolve problems, and maybe others face the same problems. > When i test ram_disk, i found no data was written into randomdisk. I debug, deep into the source code, and found that randomdisk size was less than reserved space. I think if message was logged, i would resolve the problem quickly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org