From hdfs-issues-return-231050-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Aug 27 21:14:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E4A55180674 for ; Mon, 27 Aug 2018 21:14:02 +0200 (CEST) Received: (qmail 76816 invoked by uid 500); 27 Aug 2018 19:14:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 76805 invoked by uid 99); 27 Aug 2018 19:14:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Aug 2018 19:14:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 66749C0C6E for ; Mon, 27 Aug 2018 19:14:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id o_M4XwvU0Szs for ; Mon, 27 Aug 2018 19:14:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BCC4D5F35A for ; Mon, 27 Aug 2018 19:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5AB3EE0360 for ; Mon, 27 Aug 2018 19:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1DB1F26B58 for ; Mon, 27 Aug 2018 19:14:00 +0000 (UTC) Date: Mon, 27 Aug 2018 19:14:00 +0000 (UTC) From: "Ajay Kumar (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDDS-369) Remove the containers of a dead node from the container state map MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594120#comment-16594120 ] Ajay Kumar edited comment on HDDS-369 at 8/27/18 7:13 PM: ---------------------------------------------------------- [~elek] Patch LGTM. Minor nit: Change log statement to parametrized logging. i.e {code}LOG.info("Datanode " + datanodeDetails.getUuid() + " is dead. Removing replications from the in-memory state."); LOG.info("Datanode {} is dead. Removing replications from the in-memory state.", datanodeDetails.getUuid());{code} {code}LOG.error("Can't remove container from containerStateMap " + container.getId(), e); to LOG.error("Can't remove container from containerStateMap {}", container.getId(), e);{code} Also apart from updating replica info, shouldn't this handler also update information related to storage (space left/used) for cluster? was (Author: ajayydv): [~elek] Patch LGTM. Minor nit: Change log statement to parametrized logging. i.e {code}LOG.info("Datanode " + datanodeDetails.getUuid() + " is dead. Removing replications from the in-memory state.");{code} to LOG.info("Datanode {} is dead. Removing replications from the in-memory state.", datanodeDetails.getUuid()); {code}LOG.error("Can't remove container from containerStateMap " + container.getId(), e);{code} to {code}LOG.error("Can't remove container from containerStateMap {}", container.getId(), e);{code} Also apart from updating replica info, shouldn't this handler also update information related to storage (space left/used) for cluster? > Remove the containers of a dead node from the container state map > ----------------------------------------------------------------- > > Key: HDDS-369 > URL: https://issues.apache.org/jira/browse/HDDS-369 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: SCM > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-369.001.patch, HDDS-369.002.patch > > > In case of a node is dead we need to update the container replicas information of the containerStateMap for all the containers from that specific node. > With removing the replica information we can detect the under replicated state and start the replication. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org