From hdfs-issues-return-231562-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Aug 31 04:44:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B188B180656 for ; Fri, 31 Aug 2018 04:44:08 +0200 (CEST) Received: (qmail 47985 invoked by uid 500); 31 Aug 2018 02:44:07 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 47841 invoked by uid 99); 31 Aug 2018 02:44:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Aug 2018 02:44:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B614FC6A0D for ; Fri, 31 Aug 2018 02:44:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VTjC5rJiAEZq for ; Fri, 31 Aug 2018 02:44:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E0D215F5AC for ; Fri, 31 Aug 2018 02:44:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8D380E2673 for ; Fri, 31 Aug 2018 02:44:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 75A8C26B9F for ; Fri, 31 Aug 2018 02:44:02 +0000 (UTC) Date: Fri, 31 Aug 2018 02:44:02 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13838) WebHdfsFileSystem.getFileStatus() won't return correct "snapshot enabled" status MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13838?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1659= 8151#comment-16598151 ]=20 Hudson commented on HDFS-13838: ------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14855 (See [https= ://builds.apache.org/job/Hadoop-trunk-Commit/14855/]) Revert "HDFS-13838. WebHdfsFileSystem.getFileStatus() won't return (weichiu= : rev 8aa6c4f079fd38a3230bc070c2ce837fefbc5301) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hd= fs/web/TestWebHDFS.java * (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/ha= doop/hdfs/web/JsonUtilClient.java > WebHdfsFileSystem.getFileStatus() won't return correct "snapshot enabled"= status > -------------------------------------------------------------------------= ------- > > Key: HDFS-13838 > URL: https://issues.apache.org/jira/browse/HDFS-13838 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs, webhdfs > Affects Versions: 3.1.0, 3.0.3 > Reporter: Siyao Meng > Assignee: Siyao Meng > Priority: Major > Attachments: HDFS-13838.001.patch, HDFS-13838.002.patch > > > "Snapshot enabled" status has been added in HDFS-12455 by [~ajaykumar]. > However, it is found by [~jojochuang] that=C2=A0WebHdfsFileSystem.getFile= Status() won't return the correct=C2=A0"snapshot enabled" status. The reaso= n is that JsonUtilClient.toFileStatus() did not=C2=A0check=C2=A0and append = the "snapshot enabled" flag to the resulting HdfsFileStatus object. > Proof: > In=C2=A0TestWebHDFS#testWebHdfsAllowandDisallowSnapshots(), add the follo= wing lines indicated by prepending "+": > {code:java} > // allow snapshots on /bar using webhdfs > webHdfs.allowSnapshot(bar); > +// check if snapshot status is enabled > +assertTrue(dfs.getFileStatus(bar).isSnapshotEnabled()); > +assertTrue(webHdfs.getFileStatus(bar).isSnapshotEnabled()); > {code}=C2=A0 > The first assertion will pass, as expected, while the second assertion wi= ll fail because of the reason above. > Update: > A further investigation shows that FSOperations.toJsonInner() also doesn'= t check the "snapshot enabled" bit. Therefore, "fs.getFileStatus(path).isSn= apshotEnabled()" will always return false for fs type HttpFSFileSystem/WebH= dfsFileSystem/SWebhdfsFileSystem. This will be addressed in a separate jira= HDFS-13886. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org