From hdfs-issues-return-227973-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Aug 1 03:00:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 30B52180662 for ; Wed, 1 Aug 2018 03:00:05 +0200 (CEST) Received: (qmail 81919 invoked by uid 500); 1 Aug 2018 01:00:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 81907 invoked by uid 99); 1 Aug 2018 01:00:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2018 01:00:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 82AAC180659 for ; Wed, 1 Aug 2018 01:00:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id zWch8m9W2eTz for ; Wed, 1 Aug 2018 01:00:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 204455F300 for ; Wed, 1 Aug 2018 01:00:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 49C27E262A for ; Wed, 1 Aug 2018 01:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5293B27762 for ; Wed, 1 Aug 2018 01:00:00 +0000 (UTC) Date: Wed, 1 Aug 2018 01:00:00 +0000 (UTC) From: "Chen Liang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDFS-13767) Add msync server implementation. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13767?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1656= 4576#comment-16564576 ]=20 Chen Liang edited comment on HDFS-13767 at 8/1/18 12:59 AM: ------------------------------------------------------------ Post WIP.v004 patch. The main changes are: # changed to {{getCorrectLastAppliedOrWrittenTxId}} as Erik suggested. # Add a simple unit test and had some=C2=A0minor change=C2=A0to=C2=A0{{Tes= tObserverNode}}. I was encountering some issues when running test, here are some=C2=A0suspec= ts I had=C2=A0on TestObserverNode: Currently with msync, every single call to Observer needs to catch up state= id. While when=C2=A0{{ObserverReadProxyProvider}} is created, it makes {{r= eportBadBlocks}} and {{checkAccess}} calls. These calls also need to catch = up state id. This means every time when=C2=A0=C2=A0{{ObserverReadProxyProvi= der}}=C2=A0is created there will be a=C2=A0wait... And since every unit tes= t creates a dfs cluster, for every single unit test in {{TestObserverNode}}= , there will be such a wait. I could set the period=C2=A0to a small time, b= ut that introduces=C2=A0other issues, because several tests depend on expli= citly made edits tailing calls. So I set the periods to a smaller, but not = too small number...and tests still quite some time to run. I think the right fix would be to have {{ObserverReadProxyProvider}} not=C2= =A0make those calls on being created. But make a new special call that bypa= sses the catching up (if possible). This is=C2=A0one of those hacky=C2=A0co= de=C2=A0we are planing to optimize in the future. And also, the ongoing wor= k HDFS-13523 may also simplify the tests. For now, I tend to=C2=A0believe h= aving these slow tests may be fine. was (Author: vagarychen): Post WIP.v004 patch. The main changes are: # changed to {{getCorrectLastAppliedOrWrittenTxId}} as Erik suggested. # Add a simple unit test and had some=C2=A0minor change=C2=A0to=C2=A0{{Tes= tObserverNode}}. I was encountering some issues when running test, here are some=C2=A0suspec= ts I had=C2=A0on TestObserverNode: Currently with msync, every single call to Observer needs to catch up state= id. While when=C2=A0{{ObserverReadProxyProvider}} is created, it makes {{r= eportBadBlocks}} and {{checkAccess}} calls. These calls are also read, so t= hey also need to catch up state id. This means every time when=C2=A0=C2=A0{= {ObserverReadProxyProvider}}=C2=A0is created there will be a=C2=A0wait... A= nd since every unit test creates a dfs cluster, for every single unit test = in {{TestObserverNode}}, there will be such a wait. I could set the period= =C2=A0to a small time, but that introduces=C2=A0other issues, because sever= al tests depend on explicitly made edits tailing calls. So I set the period= s to a smaller, but not too small number...and tests still quite some time = to run. I think the right fix would be to have {{ObserverReadProxyProvider}} not=C2= =A0make those read calls on being created. This is=C2=A0one of those hacky= =C2=A0code=C2=A0we are planing to optimize in the future. And also, the ong= oing work HDFS-13523 may also simplify the tests. For now, I tend to=C2=A0b= elieve having these slow tests may be fine. > Add msync server implementation. > -------------------------------- > > Key: HDFS-13767 > URL: https://issues.apache.org/jira/browse/HDFS-13767 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Chen Liang > Assignee: Chen Liang > Priority: Major > Attachments: HDFS-13767.WIP.001.patch, HDFS-13767.WIP.002.patch, = HDFS-13767.WIP.003.patch, HDFS-13767.WIP.004.patch > > > This is a followup on HDFS-13688, where msync API is introduced to {{Clie= ntProtocol}} but the server side implementation is missing.=C2=A0This is Ji= ra is to implement the server side logic. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org