From hdfs-issues-return-231404-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Aug 29 21:27:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7E884180657 for ; Wed, 29 Aug 2018 21:27:04 +0200 (CEST) Received: (qmail 55810 invoked by uid 500); 29 Aug 2018 19:27:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 55799 invoked by uid 99); 29 Aug 2018 19:27:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2018 19:27:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1873A1A1AD5 for ; Wed, 29 Aug 2018 19:27:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Fgu84MuTXeGE for ; Wed, 29 Aug 2018 19:27:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4E7185F470 for ; Wed, 29 Aug 2018 19:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 90654E00D3 for ; Wed, 29 Aug 2018 19:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4CDB723F98 for ; Wed, 29 Aug 2018 19:27:00 +0000 (UTC) Date: Wed, 29 Aug 2018 19:27:00 +0000 (UTC) From: "Mukul Kumar Singh (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDDS-280) Support ozone dist-start-stitching on openbsd/osx MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-280?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165967= 61#comment-16596761 ]=20 Mukul Kumar Singh commented on HDDS-280: ---------------------------------------- Thanks for working on this [~elek]. The patch looks good to me as well. +1 for the v3 patch, there is a minor nitpick in acceptance-test/pom.xml:47= , the indentation is off by 1. I will handle this during commit. > Support ozone dist-start-stitching on openbsd/osx > ------------------------------------------------- > > Key: HDDS-280 > URL: https://issues.apache.org/jira/browse/HDDS-280 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-280.001.patch, HDDS-280.002.patch, HDDS-280.003= .patch > > > {quote}Ozone is creating a symlink during the dist process. > Using the "ozone" directory as a destination name all the docker-based ac= ceptance tests and docker-compose files are more simple as they don't need = to have the version information in the path. > But to keep the version specific folder name in the tar file we create a = symbolic link during the tar creation. With the symbolic link and the '=E2= =80=93dereference' tar argument we can create the tar file which includes a= versioned directory (ozone-0.2.1) but we can use the a dist directory with= out the version in the name (hadoop-dist/target/ozone). > {quote} > This is the description of the current dev-support/bin/ozone-dist-tar-sti= tching. [~aw] in a comment for HDDS-276 pointed to the problem that some bs= d variants don't support the dereference command line options of the ln com= mand. > The main reason to use this approach is to get a simplified destination n= ame without the version (hadoop-dist/target/ozone instead of hadoop-dist/ta= rget/ozone-0.2.1). It simplifies the docker-compose based environments and = acceptance tests, therefore I prefer to keep the simplified destination nam= e. > The issue is the tar file creation, if and only if we need the version nu= mber in the name of the root directory inside of the tar. > Possible solutions: > # Use cp target/ozone target/ozone-0.2.1 + tar. It's simple but more slo= w and requires more space. > # Do the tar distribution from docker all the time in case of 'dereferen= ce' is not supported. Not very convenient > # Accept that tar will contain ozone directory and not ozone-0.2.1. This= is the more simple and can be improved with an additional VERSION file in = the root of the distribution. > # (+1) Use hadoop-dist/target/ozone-0.2.1 instead of hadoop-dist/target/= ozone. This is more complex for the docker based testing as we need the exp= licit names in the compose files (volume: ../../../hadoop-dist/target/ozone= -0.2.1). The structure is more complex with using version in the directory = name. > Please comment your preference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org