From hdfs-issues-return-230299-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Aug 22 18:11:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 92F5A180662 for ; Wed, 22 Aug 2018 18:11:04 +0200 (CEST) Received: (qmail 78493 invoked by uid 500); 22 Aug 2018 16:11:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 78482 invoked by uid 99); 22 Aug 2018 16:11:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 16:11:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 34235C0BF7 for ; Wed, 22 Aug 2018 16:11:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id FdXCXGSFATd3 for ; Wed, 22 Aug 2018 16:11:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6AE2E5F36D for ; Wed, 22 Aug 2018 16:11:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A7306E0110 for ; Wed, 22 Aug 2018 16:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 518C524693 for ; Wed, 22 Aug 2018 16:11:00 +0000 (UTC) Date: Wed, 22 Aug 2018 16:11:00 +0000 (UTC) From: "genericqa (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13752) fs.Path stores file path in java.net.URI causes big memory waste MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13752?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1658= 9074#comment-16589074 ]=20 genericqa commented on HDFS-13752: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 39s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m = 0s{color} | {color:red} The patch doesn't appear to include any new or modi= fied tests. Please justify why no new tests are needed for this patch. Also= please list what manual steps were performed to verify this patch. {color}= | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 21m 35s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 15= m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 53s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1= m 16s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 13m 37s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 1m 45s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1= m 1s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 15= m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m = 52s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:oran= ge} 0m 55s{color} | {color:orange} hadoop-common-project/hadoop-common: Th= e patch generated 11 new + 11 unchanged - 12 fixed =3D 22 total (was 23) {c= olor} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1= m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 11m 13s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 2m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 58s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m 2= 6s{color} | {color:green} hadoop-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 39s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 99m 41s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hadoop:ba1ab= 08 | | JIRA Issue | HDFS-13752 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1293666= 2/HDFS-13752.003.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstal= l mvnsite unit shadedclient findbugs checkstyle | | uname | Linux fcedd32295b2 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 = 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 8184739 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/24835/art= ifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/24835/= testReport/ | | Max. process+thread count | 1347 (vs. ulimit of 10000) | | modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project= /hadoop-common | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/24835= /console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > fs.Path stores file path in java.net.URI causes big memory waste > ---------------------------------------------------------------- > > Key: HDFS-13752 > URL: https://issues.apache.org/jira/browse/HDFS-13752 > Project: Hadoop HDFS > Issue Type: Improvement > Components: fs > Affects Versions: 2.7.6 > Environment: Hive 2.1.1 and hadoop 2.7.6=20 > Reporter: Barnabas Maidics > Priority: Major > Attachments: HDFS-13752.001.patch, HDFS-13752.002.patch, HDFS-137= 52.003.patch, Screen Shot 2018-07-20 at 11.12.38.png, heapdump-100000partit= ions.html, measurement.pdf > > > I was looking at=C2=A0HiveServer2 memory usage, and a big percentage of t= his was because of=C2=A0org.apache.hadoop.fs.Path, where you store file pat= hs in a java.net.URI object.=C2=A0The URI implementation stores the same st= ring in 3 different objects (see the attached image). In Hive when there ar= e many partitions this cause a big memory usage. In my particular case 42% = of memory was used by java.net.URI so it could be reduced to 14%.=C2=A0 > I wonder if the community is open to replace it with a more memory effici= ent implementation and=C2=A0what=C2=A0other things should be considered her= e?=C2=A0It can be a huge memory improvement for Hadoop=C2=A0and for Hive=C2= =A0as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org